Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 1403853002: Devtools: DOM inspection follows inspect cursor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
index 25f24a4f22eec457308a1374ec1cb99d854bbaee..ef87846425a9bcd865817581c96120612df88224 100644
--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
@@ -245,10 +245,12 @@ WebInspector.ScreencastView.prototype = {
{
if (!node)
return;
- if (event.type === "mousemove")
+ if (event.type === "mousemove") {
this.highlightDOMNode(node, this._inspectModeConfig);
- else if (event.type === "click")
+ this._domModel.nodeHighlightRequested(node.id);
+ } else if (event.type === "click") {
WebInspector.Revealer.reveal(node);
+ }
}
},
@@ -513,21 +515,6 @@ WebInspector.ScreencastView.prototype = {
},
-
- /**
- * @param {!DOMAgent.Quad} quad1
- * @param {!DOMAgent.Quad} quad2
- * @return {boolean}
- */
- _quadsAreEqual: function(quad1, quad2)
- {
- for (var i = 0; i < quad1.length; ++i) {
- if (quad1[i] !== quad2[i])
- return false;
- }
- return true;
- },
-
/**
* @param {!DOMAgent.RGBA} color
* @return {string}

Powered by Google App Engine
This is Rietveld 408576698