Devtools: DOM inspection follows inspect cursor

Devtools: DOM inspection follows inspect cursor

BUG=523418
Committed: https://crrev.com/a5275edf46616615c96e1ef161597885d5ded51b
Cr-Commit-Position: refs/heads/master@{#353902}

[sergeyv, 2015-10-13 00:31:28]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[sergeyv, 2015-10-13 00:31:28]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[dgozman, 2015-10-13 01:42:54]

https://codereview.chromium.org/1403853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1403853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/protocol.json:2925: "name":
"nodeHighlightedInOverlay",
We don't mention overlay in DOM domain. Let's call this "nodeHighlighted".

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:1949: * @param
{!DOMAgent.BackendNodeId} backendNodeId
s/backendNodeId/nodeId/ in this method

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:1957:
this.dispatchEventToListeners(WebInspector.DOMModel.Events.NodeHighlightedInOverlay,
node);
Let's also issue this event from ScreencastView to not lose functionality.

[sergeyv, 2015-10-13 21:24:18]

https://codereview.chromium.org/1403853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1403853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/protocol.json:2925: "name":
"nodeHighlightedInOverlay",
On 2015/10/13 01:42:54, dgozman wrote:
> We don't mention overlay in DOM domain. Let's call this "nodeHighlighted".

Done.

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:1949: * @param
{!DOMAgent.BackendNodeId} backendNodeId
On 2015/10/13 01:42:54, dgozman wrote:
> s/backendNodeId/nodeId/ in this method

Done.

https://codereview.chromium.org/1403853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:1957:
this.dispatchEventToListeners(WebInspector.DOMModel.Events.NodeHighlightedInOverlay,
node);
On 2015/10/13 01:42:54, dgozman wrote:
> Let's also issue this event from ScreencastView to not lose functionality.

Done.

[dgozman, 2015-10-13 21:38:14]

lgtm

[sergeyv, 2015-10-13 21:38:40]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2015-10-13 21:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403853002/40001

[commit-bot: I haz the power, 2015-10-13 23:27:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-13 23:27:54]

Patchset 3 (id:??) landed as
https://crrev.com/a5275edf46616615c96e1ef161597885d5ded51b
Cr-Commit-Position: refs/heads/master@{#353902}