Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 1403833002: Material PDF: Add metrics to count usage of PDF title and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/extract_actions.py
diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py
index 218c8f2afd2e26b6d7e9d345c651543859422a11..f36be9b61e63386108fe055c8f2f187205c3801a 100755
--- a/tools/metrics/actions/extract_actions.py
+++ b/tools/metrics/actions/extract_actions.py
@@ -191,14 +191,16 @@ def AddWebKitEditorActions(actions):
if match: # Plain call to RecordAction
actions.add(match.group(1))
-def AddClosedSourceActions(actions):
- """Add actions that are in code which is not checked out by default
+def AddPDFPluginActions(actions):
+ """Add actions that are sent by the PDF plugin.
Arguments
actions: set of actions to add to.
"""
actions.add('PDF.FitToHeightButton')
actions.add('PDF.FitToWidthButton')
+ actions.add('PDF.HasBookmarks')
+ actions.add('PDF.HasTitle')
actions.add('PDF.LoadFailure')
actions.add('PDF.LoadSuccess')
actions.add('PDF.PreviewDocumentLoadFailure')
@@ -740,9 +742,9 @@ def UpdateXml(original_xml):
AddAutomaticResetBannerActions(actions)
AddBookmarkManagerActions(actions)
AddChromeOSActions(actions)
- AddClosedSourceActions(actions)
AddExtensionActions(actions)
AddHistoryPageActions(actions)
+ AddPDFPluginActions(actions)
return PrettyPrint(actions, actions_dict, comment_nodes)
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698