Material PDF: Add metrics to count usage of PDF title and bookmarks

tools/metrics/actions/extract_actions.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
@@ skipping 173 matching lines @@
   """
   action_re = re.compile(r'''\{ [\w']+, +\w+, +"(.*)" +\},''')
 
   editor_file = os.path.join(REPOSITORY_ROOT, 'webkit', 'api', 'src',
                              'EditorClientImpl.cc')
   for line in open(editor_file):
     match = action_re.search(line)
     if match:  # Plain call to RecordAction
       actions.add(match.group(1))
 
-def AddClosedSourceActions(actions):
-  """Add actions that are in code which is not checked out by default
+def AddPDFPluginActions(actions):
+  """Add actions that are sent by the PDF plugin.
 
   Arguments
     actions: set of actions to add to.
   """
   actions.add('PDF.FitToHeightButton')
   actions.add('PDF.FitToWidthButton')
+  actions.add('PDF.HasBookmarks')
+  actions.add('PDF.HasTitle')
   actions.add('PDF.LoadFailure')
   actions.add('PDF.LoadSuccess')
   actions.add('PDF.PreviewDocumentLoadFailure')
   actions.add('PDF.PrintButton')
   actions.add('PDF.PrintPage')
   actions.add('PDF.SaveButton')
   actions.add('PDF.ZoomFromBrowser')
   actions.add('PDF.ZoomInButton')
   actions.add('PDF.ZoomOutButton')
   actions.add('PDF_Unsupported_3D')
   actions.add('PDF_Unsupported_Attachment')
   actions.add('PDF_Unsupported_Bookmarks')
   actions.add('PDF_Unsupported_Digital_Signature')
   actions.add('PDF_Unsupported_Movie')
   actions.add('PDF_Unsupported_Portfolios_Packages')
   actions.add('PDF_Unsupported_Rights_Management')
   actions.add('PDF_Unsupported_Screen')
   actions.add('PDF_Unsupported_Shared_Form')
   actions.add('PDF_Unsupported_Shared_Review')
   actions.add('PDF_Unsupported_Sound')
   actions.add('PDF_Unsupported_XFA')

[raymes, 2015/10/13 05:27:54]

Hmm can we remove the ones that are now unused?

[tsergeant, 2015/10/14 02:28:48]

isherman@, what is the procedure for removing actions from this file? If I mark
an action as obsolete in the xml file, does it need to stay in this file as
well?

[tsergeant, 2015/10/14 02:36:50]

Ah, whoops, that was a draft from yesterday. Same question goes to asvitkine@, I
guess =)

[Alexei Svitkine (slow), 2015/10/14 15:01:50]

Feel free to remove obsolete entries from this list as long as the <obsolete>
entries are still in the xml file.

 
 def AddAboutFlagsActions(actions):
   """This parses the experimental feature flags for UMA actions.
 
   Arguments:
     actions: set of actions to add to.
   """
   about_flags = os.path.join(REPOSITORY_ROOT, 'chrome', 'browser',
                              'about_flags.cc')
   flag_name_re = re.compile(r'\s*"([0-9a-zA-Z\-_]+)",\s*// FLAGS:RECORD_UMA')
@@ skipping 500 matching lines @@
   AddWebUIActions(actions)
 
   AddLiteralActions(actions)
 
   # print "Scanned {0} number of files".format(number_of_files_total)
   # print "Found {0} entries".format(len(actions))
 
   AddAutomaticResetBannerActions(actions)
   AddBookmarkManagerActions(actions)
   AddChromeOSActions(actions)
-  AddClosedSourceActions(actions)
   AddExtensionActions(actions)
   AddHistoryPageActions(actions)
+  AddPDFPluginActions(actions)
 
   return PrettyPrint(actions, actions_dict, comment_nodes)
 
 
 def main(argv):
   presubmit_util.DoPresubmitMain(argv, 'actions.xml', 'actions.old.xml',
                                  'extract_actions.py', UpdateXml)
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))