Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: pdf/out_of_process_instance.cc

Issue 1403833002: Material PDF: Add metrics to count usage of PDF title and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | tools/metrics/actions/extract_actions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/out_of_process_instance.cc
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc
index cfa11ba980be40c03c854e760bb54365d3a76219..45baee1e3c7065b6f653cb6a3330c71e821dbd32 100644
--- a/pdf/out_of_process_instance.cc
+++ b/pdf/out_of_process_instance.cc
@@ -1112,10 +1112,15 @@ void OutOfProcessInstance::DocumentLoadComplete(int page_count) {
pp::VarDictionary metadata_message;
metadata_message.Set(pp::Var(kType), pp::Var(kJSMetadataType));
std::string title = engine_->GetMetadata("Title");
- if (!base::TrimWhitespace(base::UTF8ToUTF16(title), base::TRIM_ALL).empty())
+ if (!base::TrimWhitespace(base::UTF8ToUTF16(title), base::TRIM_ALL).empty()) {
metadata_message.Set(pp::Var(kJSTitle), pp::Var(title));
+ UserMetricsRecordAction("PDF.HasTitle");
+ }
- metadata_message.Set(pp::Var(kJSBookmarks), engine_->GetBookmarks());
+ pp::VarArray bookmarks = engine_->GetBookmarks();
+ metadata_message.Set(pp::Var(kJSBookmarks), bookmarks);
+ if (bookmarks.GetLength() > 0)
+ UserMetricsRecordAction("PDF.HasBookmarks");
PostMessage(metadata_message);
pp::VarDictionary progress_message;
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | tools/metrics/actions/extract_actions.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698