Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: tools/metrics/actions/actions.xml

Issue 1403803003: Add metrics for window.external.AddSearchProvider and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index fc660109a210ca82c41a4afd9f70ef1a17e9d898..e7928a32d89f16615fdbaeb5c1722637a4f879c2 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -13035,4 +13035,32 @@ should be able to be added at any place in this file.
</description>
</action>
+<action name="window.external.AddSearchProvider">
+ <owner>estade@chromium.org</owner>
+ <description>The page called window.external.AddSearchProvider.</description>
+</action>
+
+<action name="window.external.AddSearchProvider_success">
Mark P 2015/10/13 21:16:29 _success doesn't seem like the right name for this
Evan Stade 2015/10/13 21:36:34 We always either do nothing or request confirmatio
Mark P 2015/10/13 21:43:01 I know this point is basically moot now, but I rea
+ <owner>estade@chromium.org</owner>
+ <description>
+ The page called window.external.AddSearchProvider and the &quot;Confirm Add
+ Search Provider&quot; dialog was actually shown.
+ </description>
+</action>
+
+<action name="window.external.IsSearchProviderInstalled">
+ <owner>estade@chromium.org</owner>
+ <description>
+ The page called window.external.IsSearchProviderInstalled.
+ </description>
+</action>
+
+<action name="window.external.IsSearchProviderInstalled_success">
+ <owner>estade@chromium.org</owner>
+ <description>
+ The page called window.external.IsSearchProviderInstalled and the browser
+ didn't throw an exception.
+ </description>
+</action>
+
</actions>
« chrome/renderer/external_extension.cc ('K') | « chrome/renderer/external_extension.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698