Chromium Code Reviews Chromium Code Reviews
Issue 1403803003:
Add metrics for window.external.AddSearchProvider and (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2014 The Chromium Authors. All rights reserved. | 2 Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <!-- | 7 <!-- |
| 8 This file is a comprehensive list of Chrome user actions along with the owner | 8 This file is a comprehensive list of Chrome user actions along with the owner |
| 9 and description for each user action. A user action should be tied to an actual | 9 and description for each user action. A user action should be tied to an actual |
| 10 action taken by a user. It should be logged immediatly after a user takes the | 10 action taken by a user. It should be logged immediatly after a user takes the |
| (...skipping 13017 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 13028 | 13028 |
| 13029 <action name="webapps.AddShortcut.Manifest"> | 13029 <action name="webapps.AddShortcut.Manifest"> |
| 13030 <owner>mlamouri@chromium.org</owner> | 13030 <owner>mlamouri@chromium.org</owner> |
| 13031 <description> | 13031 <description> |
| 13032 Shortcut added to the homescreen with a valid Manifest. This action will be | 13032 Shortcut added to the homescreen with a valid Manifest. This action will be |
| 13033 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions | 13033 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions |
| 13034 to keep a trend of whether the webapp also add meta tags. | 13034 to keep a trend of whether the webapp also add meta tags. |
| 13035 </description> | 13035 </description> |
| 13036 </action> | 13036 </action> |
| 13037 | 13037 |
| 13038 <action name="window.external.AddSearchProvider"> | |
| 13039 <owner>estade@chromium.org</owner> | |
| 13040 <description>The page called window.external.AddSearchProvider.</description> | |
| 13041 </action> | |
| 13042 | |
| 13043 <action name="window.external.AddSearchProvider_success"> | |
|
Mark P
2015/10/13 21:16:29
_success doesn't seem like the right name for this
Evan Stade
2015/10/13 21:36:34
We always either do nothing or request confirmatio
Mark P
2015/10/13 21:43:01
I know this point is basically moot now, but I rea
| |
| 13044 <owner>estade@chromium.org</owner> | |
| 13045 <description> | |
| 13046 The page called window.external.AddSearchProvider and the "Confirm Add | |
| 13047 Search Provider" dialog was actually shown. | |
| 13048 </description> | |
| 13049 </action> | |
| 13050 | |
| 13051 <action name="window.external.IsSearchProviderInstalled"> | |
| 13052 <owner>estade@chromium.org</owner> | |
| 13053 <description> | |
| 13054 The page called window.external.IsSearchProviderInstalled. | |
| 13055 </description> | |
| 13056 </action> | |
| 13057 | |
| 13058 <action name="window.external.IsSearchProviderInstalled_success"> | |
| 13059 <owner>estade@chromium.org</owner> | |
| 13060 <description> | |
| 13061 The page called window.external.IsSearchProviderInstalled and the browser | |
| 13062 didn't throw an exception. | |
| 13063 </description> | |
| 13064 </action> | |
| 13065 | |
| 13038 </actions> | 13066 </actions> |
| OLD | NEW |
