Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 1403793004: Enable NaCl glibc tests on ARM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/nacl/nacl_browsertest_uma.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 166
167 // PNaCl tests take a long time on windows debug builds 167 // PNaCl tests take a long time on windows debug builds
168 // and sometimes time out. Disable until it is made faster: 168 // and sometimes time out. Disable until it is made faster:
169 // https://code.google.com/p/chromium/issues/detail?id=177555 169 // https://code.google.com/p/chromium/issues/detail?id=177555
170 #if (defined(OS_WIN) && !defined(NDEBUG)) 170 #if (defined(OS_WIN) && !defined(NDEBUG))
171 # define MAYBE_PNACL(test_name) DISABLED_##test_name 171 # define MAYBE_PNACL(test_name) DISABLED_##test_name
172 #else 172 #else
173 # define MAYBE_PNACL(test_name) test_name 173 # define MAYBE_PNACL(test_name) test_name
174 #endif 174 #endif
175 175
176 // NaCl glibc tests are included for x86 only, as there is no glibc support 176 // NaCl glibc toolchain is not available on MIPS
177 // for other architectures (ARM/MIPS). 177 #if defined(ARCH_CPU_MIPS_FAMILY) || defined(DISABLE_NACL_BROWSERTESTS)
178 #if defined(ARCH_CPU_X86_FAMILY) && \ 178 # define MAYBE_GLIBC(test_name) DISABLED_##test_name
179 !defined(DISABLE_NACL_BROWSERTESTS) 179 #else
180 # define MAYBE_GLIBC(test_name) test_name 180 # define MAYBE_GLIBC(test_name) test_name
181 #else
182 # define MAYBE_GLIBC(test_name) DISABLED_##test_name
183 #endif 181 #endif
184 182
185 // Currently, we only support it on x86-32 or ARM architecture. 183 // Currently, we only support it on x86-32 or ARM architecture.
186 // TODO(hidehiko,mazda): Enable this on x86-64, too, when it is supported. 184 // TODO(hidehiko,mazda): Enable this on x86-64, too, when it is supported.
187 #if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER) && \ 185 #if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER) && \
188 !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \ 186 !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \
189 !defined(LEAK_SANITIZER) && \ 187 !defined(LEAK_SANITIZER) && \
190 (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL)) 188 (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
191 # define MAYBE_NONSFI(test_case) test_case 189 # define MAYBE_NONSFI(test_case) test_case
192 #else 190 #else
(...skipping 13 matching lines...) Expand all
206 204
207 #define NACL_BROWSER_TEST_F(suite, name, body) \ 205 #define NACL_BROWSER_TEST_F(suite, name, body) \
208 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \ 206 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
209 body \ 207 body \
210 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \ 208 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \
211 body \ 209 body \
212 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \ 210 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \
213 body 211 body
214 212
215 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 213 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/test/nacl/nacl_browsertest_uma.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698