Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1403763002: Reland improve perf_basic_prof filename reporting (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
Reviewers:
Yang, yurys, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland improve perf_basic_prof filename reporting Using perf-basic-prof in the test-case was problematic on windows. Use CodeEventLogger directly. Previous issue: https://codereview.chromium.org/1396843004/ R=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org BUG=chromium:539892 LOG=N Committed: https://crrev.com/701ba0b255f9c34f4b8c43584ef1e35040474e7d Cr-Commit-Position: refs/heads/master@{#31197} patch from issue 1396843004 at patchset 60001 (http://crrev.com/1396843004#ps60001) Committed: https://crrev.com/010897c16adb46d3fe403eab525502a63e174b0c Cr-Commit-Position: refs/heads/master@{#31237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M src/log.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 2 months ago (2015-10-12 17:46:47 UTC) #1
Jakob Kummerow
LGTM with a workflow nit for next time: The preferred way to reland a patch ...
5 years, 2 months ago (2015-10-13 11:25:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403763002/1
5 years, 2 months ago (2015-10-13 12:20:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 12:45:19 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 12:45:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/010897c16adb46d3fe403eab525502a63e174b0c
Cr-Commit-Position: refs/heads/master@{#31237}

Powered by Google App Engine
This is Rietveld 408576698