Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1403673003: Add additional hosts to hard-coded service URL presubmit check (Closed)

Created:
5 years, 2 months ago by reillyi
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additional hosts to hard-coded service URL presubmit check This adds additional domains to the root PRESUBMIT check, "_CheckHardcodedGoogleHostsInLowerLayers", based on hostnames currently used in Chromium. Previously, this check only validated that "google.com" was not hard-coded, but did not catch other common hostnames: - gstatic.com - googleapis.com - googlezip.net - googledrive.com - appspot.com Note that this check is non-blocking, only prompting the user with a warning before continuing the submit operation. BUG=164568 TEST=PRESUBMIT_test.py Committed: https://crrev.com/3896573612b050f3e065b1188098f68bdae0b696 Cr-Commit-Position: refs/heads/master@{#359869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
reillyi
Hi jochen, PTAL at this change to add additional URLs to the PRESUBMIT check for ...
5 years, 2 months ago (2015-10-12 23:55:33 UTC) #2
jochen (gone - plz use gerrit)
your account appears to not be covered by the CCLA from amazon?
5 years, 2 months ago (2015-10-13 17:24:47 UTC) #3
reillyi
On 2015/10/13 at 17:24:47, jochen wrote: > your account appears to not be covered by ...
5 years, 2 months ago (2015-10-13 17:26:40 UTC) #4
reillyi
On 2015/10/13 at 17:26:40, reillyi wrote: > On 2015/10/13 at 17:24:47, jochen wrote: > > ...
5 years, 2 months ago (2015-10-19 23:45:32 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 08:16:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403673003/1
5 years, 1 month ago (2015-11-16 18:04:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 18:27:43 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 18:28:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3896573612b050f3e065b1188098f68bdae0b696
Cr-Commit-Position: refs/heads/master@{#359869}

Powered by Google App Engine
This is Rietveld 408576698