PRESUBMIT.py - Issue 1403673003: Add additional hosts to hard-coded service URL presubmit check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1403673003: Add additional hosts to hard-coded service URL presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index be7dccfb15d91bb431bd9b3315b6b272a0a2658d..a0a59081c479979534b244ec0db08704ffbbbcd9 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -884,7 +884,8 @@ def _CheckHardcodedGoogleHostsInLowerLayers(input_api, output_api):

_TEST_CODE_EXCLUDED_PATHS +

input_api.DEFAULT_BLACK_LIST))

- base_pattern = '"[^"]*google\.com[^"]*"'

+ base_pattern = ('"[^"]*(google|googleapis|googlezip|googledrive|appspot)'

+ '\.(com|net)[^"]*"')

comment_pattern = input_api.re.compile('//.*%s' % base_pattern)

pattern = input_api.re.compile(base_pattern)

problems = [] # items are (filename, line_number, line)

« no previous file with comments | « AUTHORS ('k') | PRESUBMIT_test.py » ('j') | no next file with comments »