Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: storage/browser/quota/quota_manager.h

Issue 1403673002: Add Quota.TimeSinceOriginEvicted UMA histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix histogram comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/quota/quota_manager.h
diff --git a/storage/browser/quota/quota_manager.h b/storage/browser/quota/quota_manager.h
index 3e053887b1ff41fb41810af6b5bfa9f134f6aa3d..5ea598c42b01b9886ab453e1721729b3c49870b6 100644
--- a/storage/browser/quota/quota_manager.h
+++ b/storage/browser/quota/quota_manager.h
@@ -204,6 +204,7 @@ class STORAGE_EXPORT QuotaManager
virtual void DeleteOriginData(const GURL& origin,
StorageType type,
int quota_client_mask,
+ bool is_eviction,
michaeln 2015/10/13 21:35:36 let's not change the public method sig to add this
calamity 2015/10/15 07:56:43 Done.
const StatusCallback& callback);
void DeleteHostData(const std::string& host,
StorageType type,
@@ -266,6 +267,8 @@ class STORAGE_EXPORT QuotaManager
static const int kEvictionIntervalInMilliSeconds;
+ static const char kTimeSinceOriginEvictedHistogram[];
Ilya Sherman 2015/10/13 18:56:18 nit: The other histogram names are inlined, so it
calamity 2015/10/15 07:56:43 This is used in tests.
+
// These are kept non-const so that test code can change the value.
// TODO(kinuko): Make this a real const value and add a proper way to set
// the quota for syncable storage. (http://crbug.com/155488)
@@ -363,7 +366,9 @@ class STORAGE_EXPORT QuotaManager
// Methods for eviction logic.
void StartEviction();
- void DeleteOriginFromDatabase(const GURL& origin, StorageType type);
+ void DeleteOriginFromDatabase(const GURL& origin,
+ StorageType type,
+ bool is_eviction);
void DidOriginDataEvicted(QuotaStatusCode status);

Powered by Google App Engine
This is Rietveld 408576698