Add Quota.TimeSinceOriginEvicted UMA histogram.

storage/browser/quota/quota_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_
 #define STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_
 
 #include <deque>
 #include <list>
 #include <map>
@@ skipping 186 matching lines @@
   // DeleteOriginData and DeleteHostData (surprisingly enough) delete data of a
   // particular StorageType associated with either a specific origin or set of
   // origins. Each method additionally requires a |quota_client_mask| which
   // specifies the types of QuotaClients to delete from the origin. This is
   // specified by the caller as a bitmask built from QuotaClient::IDs. Setting
   // the mask to QuotaClient::kAllClientsMask will remove all clients from the
   // origin, regardless of type.
   virtual void DeleteOriginData(const GURL& origin,
                                 StorageType type,
                                 int quota_client_mask,
+                                bool is_eviction,

[michaeln, 2015/10/13 21:35:36]

let's not change the public method sig to add this param

[calamity, 2015/10/15 07:56:43]

Done.

                                 const StatusCallback& callback);
   void DeleteHostData(const std::string& host,
                       StorageType type,
                       int quota_client_mask,
                       const StatusCallback& callback);
 
   // Called by UI and internal modules.
   void GetAvailableSpace(const AvailableSpaceCallback& callback);
   void GetTemporaryGlobalQuota(const QuotaCallback& callback);
 
@@ skipping 42 matching lines @@
   static const int kPerHostTemporaryPortion;
 
   static const int64 kPerHostPersistentQuotaLimit;
 
   static const char kDatabaseName[];
 
   static const int kThresholdOfErrorsToBeBlacklisted;
 
   static const int kEvictionIntervalInMilliSeconds;
 
+  static const char kTimeSinceOriginEvictedHistogram[];

[Ilya Sherman, 2015/10/13 18:56:18]

nit: The other histogram names are inlined, so it probably makes sense to inline
this one too.

[calamity, 2015/10/15 07:56:43]

This is used in tests.

+
   // These are kept non-const so that test code can change the value.
   // TODO(kinuko): Make this a real const value and add a proper way to set
   // the quota for syncable storage. (http://crbug.com/155488)
   static int64 kMinimumPreserveForSystem;
   static int64 kSyncableStorageDefaultHostQuota;
 
  protected:
   ~QuotaManager() override;
 
  private:
@@ skipping 77 matching lines @@
       const GURL& origin,
       StorageType type,
       int64 delta,
       base::Time modified_time);
 
   void DumpQuotaTable(const DumpQuotaTableCallback& callback);
   void DumpOriginInfoTable(const DumpOriginInfoTableCallback& callback);
 
   // Methods for eviction logic.
   void StartEviction();
-  void DeleteOriginFromDatabase(const GURL& origin, StorageType type);
+  void DeleteOriginFromDatabase(const GURL& origin,
+                                StorageType type,
+                                bool is_eviction);
 
   void DidOriginDataEvicted(QuotaStatusCode status);
 
   void ReportHistogram();
   void DidGetTemporaryGlobalUsageForHistogram(int64 usage,
                                               int64 unlimited_usage);
   void DidGetPersistentGlobalUsageForHistogram(int64 usage,
                                                int64 unlimited_usage);
 
   // QuotaEvictionHandler.
@@ skipping 91 matching lines @@
 
 struct QuotaManagerDeleter {
   static void Destruct(const QuotaManager* manager) {
     manager->DeleteOnCorrectThread();
   }
 };
 
 }  // namespace storage
 
 #endif  // STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_