Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1403613004: Revert of Disable support for swapped out RenderFrame(Host) and add instrumentation (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable support for swapped out RenderFrame(Host) and add instrumentation (patchset #2 id:20001 of https://codereview.chromium.org/1397323004/ ) Reason for revert: There are enough dumps at this time and this CL is no longer needed. Original issue's description: > Disable support for swapped out RenderFrame(Host) and add instrumentation > > This CL is aiming to collect information about cases where the > FocusController's focused frame is set to a RemoteFrame. This is the root > cause of the crash in https://crbug.com/541578. > > BUG=541578, 357747 > > Committed: https://crrev.com/144cbce186be2afe854b7c5d9ba6780fbaea07b8 > Cr-Commit-Position: refs/heads/master@{#353847} TBR=dcheng@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=541578, 357747 Committed: https://crrev.com/7155b70cdb939ebb07013eebfeaec23ad3ce2f15 Cr-Commit-Position: refs/heads/master@{#354013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M content/common/site_isolation_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Created Revert of Disable support for swapped out RenderFrame(Host) and add instrumentation
5 years, 2 months ago (2015-10-14 13:37:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403613004/1
5 years, 2 months ago (2015-10-14 13:38:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 13:39:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7155b70cdb939ebb07013eebfeaec23ad3ce2f15 Cr-Commit-Position: refs/heads/master@{#354013}
5 years, 2 months ago (2015-10-14 13:40:45 UTC) #4
dcheng
5 years, 2 months ago (2015-10-14 16:39:21 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698