Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1397323004: Disable support for swapped out RenderFrame(Host) and add instrumentation (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable support for swapped out RenderFrame(Host) and add instrumentation This CL is aiming to collect information about cases where the FocusController's focused frame is set to a RemoteFrame. This is the root cause of the crash in https://crbug.com/541578. BUG=541578, 357747 Committed: https://crrev.com/144cbce186be2afe854b7c5d9ba6780fbaea07b8 Cr-Commit-Position: refs/heads/master@{#353847}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M content/common/site_isolation_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
nasko
Hey Daniel, Can you review this CL for me? It is disabling swapped out again ...
5 years, 2 months ago (2015-10-12 23:04:02 UTC) #2
dcheng
+rsesek, it should be safe to call DumpWithoutCrashing on all platforms now, right? https://crbug.com/349600 is ...
5 years, 2 months ago (2015-10-12 23:25:52 UTC) #4
dcheng
actual change lgtm, let's just make sure DumpWithoutCrashing is in fact, not crashing =)
5 years, 2 months ago (2015-10-13 00:23:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397323004/20001
5 years, 2 months ago (2015-10-13 00:43:41 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 01:49:42 UTC) #9
Robert Sesek
It should be safe, yes.
5 years, 2 months ago (2015-10-13 20:15:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397323004/20001
5 years, 2 months ago (2015-10-13 20:37:46 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 20:58:26 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/144cbce186be2afe854b7c5d9ba6780fbaea07b8 Cr-Commit-Position: refs/heads/master@{#353847}
5 years, 2 months ago (2015-10-13 21:01:31 UTC) #14
nasko
5 years, 2 months ago (2015-10-14 13:37:27 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1403613004/ by nasko@chromium.org.

The reason for reverting is: There are enough dumps at this time and this CL is
no longer needed..

Powered by Google App Engine
This is Rietveld 408576698