Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 140343002: extensions: Relocate pref name constants. (Closed)

Created:
6 years, 11 months ago by Daniel Erat
Modified:
6 years, 11 months ago
Reviewers:
Yoyo Zhou, Ilya Sherman, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, nkostylev+watch_chromium.org, vandebo (ex-Chrome), Lei Zhang, tfarina, dbeam+watch-ntp_chromium.org, Greg Billock, asvitkine+watch_chromium.org, tommycli, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, jar (doing other things), davemoore+watch_chromium.org, pedrosimonetti+watch_chromium.org, not at google - send to devlin, James Cook
Visibility:
Public.

Description

extensions: Relocate pref name constants. Move extension-related pref name constants used by the ExtensionPrefs class from chrome/common/pref_names.h to extensions/browser/pref_names.h. Remove "Extension" from the beginning of the constant identifiers and "Pref" from the end since it seemed redundant now that they're in the extensions::pref_names namespace. Also delete prefs::kExtensionBlacklistUpdateVersion since it hasn't been used in about a year. BUG=313284 TBR=isherman@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245374

Patch Set 1 #

Patch Set 2 : add missing include for mac #

Total comments: 2

Patch Set 3 : sort constants and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -238 lines) Patch
chrome/browser/apps/app_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
chrome/browser/extensions/api/management/management_browsertest.cc View 7 chunks +11 lines, -7 lines 0 comments Download
chrome/browser/extensions/api/messaging/native_message_process_host.cc View 3 chunks +6 lines, -5 lines 0 comments Download
chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +4 lines, -3 lines 0 comments Download
chrome/browser/extensions/extension_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/extension_prefs.cc View 19 chunks +39 lines, -45 lines 0 comments Download
chrome/browser/extensions/extension_service.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
chrome/browser/extensions/extension_service_unittest.cc View 9 chunks +13 lines, -11 lines 0 comments Download
chrome/browser/extensions/extension_toolbar_model.cc View 4 chunks +9 lines, -5 lines 0 comments Download
chrome/browser/extensions/external_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/external_policy_loader.cc View 2 chunks +4 lines, -3 lines 0 comments Download
chrome/browser/extensions/external_policy_loader_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/extensions/install_tracker.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/extensions/install_verifier.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
chrome/browser/extensions/policy_handlers.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/extensions/policy_handlers_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
chrome/browser/extensions/standard_management_policy_provider.cc View 2 chunks +6 lines, -5 lines 0 comments Download
chrome/browser/extensions/updater/extension_updater.cc View 7 chunks +7 lines, -8 lines 0 comments Download
chrome/browser/media_galleries/media_galleries_preferences.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/policy/configuration_policy_handler_list_factory.cc View 3 chunks +7 lines, -6 lines 0 comments Download
chrome/browser/prefs/chrome_pref_service_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
chrome/browser/profiles/profile.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/ui/app_list/recommended_apps.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
chrome/browser/ui/cocoa/extensions/browser_actions_controller_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/ui/views/toolbar/browser_actions_container.cc View 2 chunks +5 lines, -3 lines 0 comments Download
chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
chrome/common/pref_names.h View 1 2 4 chunks +0 lines, -22 lines 0 comments Download
chrome/common/pref_names.cc View 1 2 4 chunks +0 lines, -71 lines 0 comments Download
extensions/browser/pref_names.h View 1 2 1 chunk +80 lines, -10 lines 0 comments Download
extensions/browser/pref_names.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
This ended up being more manual than I would've liked. :-(
6 years, 11 months ago (2014-01-16 00:32:35 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/140343002/diff/50001/extensions/browser/pref_names.h File extensions/browser/pref_names.h (right): https://codereview.chromium.org/140343002/diff/50001/extensions/browser/pref_names.h#newcode31 extensions/browser/pref_names.h:31: extern const char kLastChromeVersion[]; Can these be in ...
6 years, 11 months ago (2014-01-16 19:49:04 UTC) #2
Daniel Erat
https://codereview.chromium.org/140343002/diff/50001/extensions/browser/pref_names.h File extensions/browser/pref_names.h (right): https://codereview.chromium.org/140343002/diff/50001/extensions/browser/pref_names.h#newcode31 extensions/browser/pref_names.h:31: extern const char kLastChromeVersion[]; On 2014/01/16 19:49:05, Yoyo Zhou ...
6 years, 11 months ago (2014-01-16 20:50:30 UTC) #3
Daniel Erat
TBR isherman@ and sky@
6 years, 11 months ago (2014-01-16 21:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/140343002/110001
6 years, 11 months ago (2014-01-16 21:15:03 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:32:31 UTC) #6
Message was sent while issue was closed.
Change committed as 245374

Powered by Google App Engine
This is Rietveld 408576698