Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2801)

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 140343002: extensions: Relocate pref name constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort constants and merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_toolbar_model.cc
diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc
index e180acfcaeed0912105cc218f6110f5b6d45d92c..b1bb1a07e8feae4abe429038a9866bd4e1d4532c 100644
--- a/chrome/browser/extensions/extension_toolbar_model.cc
+++ b/chrome/browser/extensions/extension_toolbar_model.cc
@@ -24,6 +24,7 @@
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/web_contents.h"
+#include "extensions/browser/pref_names.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/feature_switch.h"
@@ -57,13 +58,15 @@ ExtensionToolbarModel::ExtensionToolbarModel(
this, chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
content::Source<extensions::ExtensionPrefs>(extension_prefs_));
- visible_icon_count_ = prefs_->GetInteger(prefs::kExtensionToolbarSize);
+ visible_icon_count_ = prefs_->GetInteger(
+ extensions::pref_names::kToolbarSize);
pref_change_registrar_.Init(prefs_);
pref_change_callback_ =
base::Bind(&ExtensionToolbarModel::OnExtensionToolbarPrefChange,
base::Unretained(this));
- pref_change_registrar_.Add(prefs::kExtensionToolbar, pref_change_callback_);
+ pref_change_registrar_.Add(extensions::pref_names::kToolbar,
+ pref_change_callback_);
}
ExtensionToolbarModel::~ExtensionToolbarModel() {
@@ -166,7 +169,7 @@ ExtensionToolbarModel::Action ExtensionToolbarModel::ExecuteBrowserAction(
void ExtensionToolbarModel::SetVisibleIconCount(int count) {
visible_icon_count_ =
count == static_cast<int>(toolbar_items_.size()) ? -1 : count;
- prefs_->SetInteger(prefs::kExtensionToolbarSize, visible_icon_count_);
+ prefs_->SetInteger(extensions::pref_names::kToolbarSize, visible_icon_count_);
}
void ExtensionToolbarModel::Observe(
@@ -391,9 +394,10 @@ void ExtensionToolbarModel::UpdatePrefs() {
return;
// Don't observe change caused by self.
- pref_change_registrar_.Remove(prefs::kExtensionToolbar);
+ pref_change_registrar_.Remove(extensions::pref_names::kToolbar);
extension_prefs_->SetToolbarOrder(last_known_positions_);
- pref_change_registrar_.Add(prefs::kExtensionToolbar, pref_change_callback_);
+ pref_change_registrar_.Add(extensions::pref_names::kToolbar,
+ pref_change_callback_);
}
int ExtensionToolbarModel::IncognitoIndexToOriginal(int incognito_index) {
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/external_policy_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698