Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403303012: Re-land "Extend the mDNS package with a native extension used on Mac OS" (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
ricow1, karlklose
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land "Extend the mDNS package with a native extension used on Mac OS" This re-lands commit 7b02aeda7e019a7daa08b2002be956150aaae4e2 which was reverted in commit 6fd4f290758b3843ee1ba5a05b37276c73051e27. The following changes has been made: 1. Fixed the include file name for Mac OS compilation 2. Moved the native extension to a deferred loaded library 3. Don't run tests of the native extension on ARM R=ricow@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/350e3563ff6cdefd92d1d5b6c23f84e9943b404b

Patch Set 1 #

Patch Set 2 : Fixes to the original change #

Total comments: 2

Patch Set 3 : Added mussing scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -131 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
M build.ninja View 1 chunk +1 line, -0 lines 0 comments Download
M fletch.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/mdns/lib/mdns.dart View 2 chunks +32 lines, -78 lines 0 comments Download
A pkg/mdns/lib/native/libmdns_extension_lib.dylib.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/mdns/lib/native/libmdns_extension_lib.so.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/mdns/lib/src/constants.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/mdns/lib/src/lookup_resolver.dart View 2 chunks +9 lines, -6 lines 0 comments Download
A + pkg/mdns/lib/src/native_extension_api.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A pkg/mdns/lib/src/native_extension_client.dart View 1 1 chunk +106 lines, -0 lines 0 comments Download
A + pkg/mdns/lib/src/native_protocol_client.dart View 4 chunks +7 lines, -25 lines 0 comments Download
M pkg/mdns/test/decode_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/mdns/test/lookup_resolver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/mdns/test/native_extension_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A src/pkg/mdns/README View 1 chunk +26 lines, -0 lines 0 comments Download
A + src/pkg/mdns/copy_dylib.sh View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/pkg/mdns/copy_so.sh View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A src/pkg/mdns/mdns.gyp View 1 chunk +43 lines, -0 lines 0 comments Download
A src/pkg/mdns/mdns_extension.h View 1 chunk +20 lines, -0 lines 0 comments Download
A src/pkg/mdns/mdns_extension.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A src/pkg/mdns/mdns_extension_linux.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A src/pkg/mdns/mdns_extension_macos.cc View 1 1 chunk +131 lines, -0 lines 0 comments Download
A src/pkg/mdns/upload_dylib.sh View 1 chunk +14 lines, -0 lines 0 comments Download
A src/pkg/mdns/upload_so.sh View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M tests/fletch_tests/all_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/fletch_tests/fletch_tests.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/mdns_tests/mdns_tests.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M tools/testing/dart/fletch_warnings_suite.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-02 15:49:50 UTC) #2
ricow1
lgtm https://codereview.chromium.org/1403303012/diff/20001/src/pkg/mdns/README File src/pkg/mdns/README (right): https://codereview.chromium.org/1403303012/diff/20001/src/pkg/mdns/README#newcode22 src/pkg/mdns/README:22: On Linux replace _dylib with _so in the ...
5 years, 1 month ago (2015-11-03 05:56:36 UTC) #3
Søren Gjesse
https://codereview.chromium.org/1403303012/diff/20001/src/pkg/mdns/README File src/pkg/mdns/README (right): https://codereview.chromium.org/1403303012/diff/20001/src/pkg/mdns/README#newcode22 src/pkg/mdns/README:22: On Linux replace _dylib with _so in the two ...
5 years, 1 month ago (2015-11-03 07:19:56 UTC) #4
Søren Gjesse
5 years, 1 month ago (2015-11-03 07:22:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
350e3563ff6cdefd92d1d5b6c23f84e9943b404b.

Powered by Google App Engine
This is Rietveld 408576698