src/pkg/mdns/README - Issue 1403303012: Re-land "Extend the mDNS package with a native extension used on Mac OS"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/pkg/mdns/README

Issue 1403303012: Re-land "Extend the mDNS package with a native extension used on Mac OS" (Closed) Base URL: git@github.com:dart-lang/fletch.git@master

Patch Set: Fixes to the original change Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2015, the Fletch project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE.md file.

	4

	5 This is a native extension used by the mDNS package (in pkg/mdns) to

	6 get mDNS support on Mac OS using the C API. When making changes to

	7 this code the native extension need to be updated namually in the

	8 package.

	9

	10 When testing changes on Mac OS:

	11

	12 $ ninja -C out/ReleaseX64

	13 $ src/pkg/mdns/copy_dylib.sh

	14

	15 When the new .dylib file is working upload it to GCS

	16

	17 $ src/pkg/mdns/upload_dylib.sh

	18

	19 The resulting .sha1 file (in pkg/mdns/lib/native) is then updated and

	20 checked in.

	21

	22 On Linux replace _dylib with _so in the two script names.
	ricow1 2015/11/03 05:56:36 I don't see those two scripts I don't see those two scripts Søren Gjesse 2015/11/03 07:19:56 Good catch. Forgot to add. Show quoted text On 2015/11/03 05:56:36, ricow1 wrote: > I don't see those two scripts Good catch. Forgot to add.
	23

	24 The extension is also implemented for Linux, but in a no-operation

	25 mode with just simple echo testing. The reason for this is that the

	26 mDNS package can then always load the dynamic library.

OLD	NEW

« no previous file with comments | « pkg/mdns/test/native_extension_test.dart ('k') | src/pkg/mdns/copy_dylib.sh » ('j') | no next file with comments »