Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 1403153003: Revert of Make dates default to the local timezone if none specified (https://codereview.chromium.… (Closed)

Created:
5 years, 2 months ago by ulan
Modified:
5 years, 2 months ago
Reviewers:
hichris123, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make dates default to the local timezone if none specified (https://codereview.chromium.org/1229903004/) Even though the change is ES6 spec compliant, we decided to revert to be consistent with other browsers and work on fixing the spec. Original issue's description: > Make dates default to the local timezone if none specified > > In ES5, dates were supposed to default to UTC if no timezone was specified. However, this changed in ES6, which specified that dates should be in the local timezone if no timezone was specified. This CL updates our behavior to match that part of the ES6 spec. > BUG=chromium:391730, v8:4242 > LOG=Y > Committed: https://crrev.com/f06754a8e1d305a43560705f6c167d85d40e602d > Cr-Commit-Position: refs/heads/master@{#29854} BUG=chromium:543320, chromium:539813 LOG=NO Committed: https://crrev.com/dd3f1ecf719afd21b4c695c776b4da2fb494ef92 Cr-Commit-Position: refs/heads/master@{#31295}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -75 lines) Patch
M src/dateparser.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/dateparser-inl.h View 1 6 chunks +15 lines, -13 lines 0 comments Download
M test/mjsunit/date.js View 1 chunk +54 lines, -54 lines 0 comments Download
M test/mjsunit/date-parse.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ulan
PTAL
5 years, 2 months ago (2015-10-15 11:49:26 UTC) #2
rossberg
lgtm
5 years, 2 months ago (2015-10-15 11:51:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403153003/20001
5 years, 2 months ago (2015-10-15 11:52:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 12:17:59 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dd3f1ecf719afd21b4c695c776b4da2fb494ef92 Cr-Commit-Position: refs/heads/master@{#31295}
5 years, 2 months ago (2015-10-15 12:18:27 UTC) #7
hichris123
Sounds good. Didn't realize FF had differing behavior, sorry.
5 years, 2 months ago (2015-10-15 19:49:45 UTC) #8
mj1856
5 years, 2 months ago (2015-10-16 03:52:34 UTC) #9
Message was sent while issue was closed.
No... Please don't unwind this!  It is a necessary and much anticipated new
feature of ES6.  See my comments in the issue.

Powered by Google App Engine
This is Rietveld 408576698