Make dates default to the local timezone if none specified

Make dates default to the local timezone if none specified

In ES5, dates were supposed to default to UTC if no timezone was specified. However, this changed in ES6, which specified that dates should be in the local timezone if no timezone was specified. This CL updates our behavior to match that part of the ES6 spec.

BUG=chromium:391730, v8:4242
LOG=Y

Committed: https://crrev.com/f06754a8e1d305a43560705f6c167d85d40e602d
Cr-Commit-Position: refs/heads/master@{#29854}

[ulan, 2015-07-24 13:56:25]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2015-07-24 13:56:25]

lgtm, thanks!

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h
File src/dateparser-inl.h (right):

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or legacy
dates compatible
Please update this comment to ES6.

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
src/dateparser-inl.h:43: //           (following the ES6 standard vs. ES5).
We can now drop the part in parenthesis.

[hichris123, 2015-07-24 14:23:16]

On 2015/07/24 13:56:25, ulan wrote:
> lgtm, thanks!
> 
> https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h
> File src/dateparser-inl.h (right):
> 
>
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
> src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or legacy
> dates compatible
> Please update this comment to ES6.
> 
>
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
> src/dateparser-inl.h:43: //           (following the ES6 standard vs. ES5).
> We can now drop the part in parenthesis.

One quick note -- I'll address the comments in a bit -- the method is named
ParseES5DateTime, so should we update that as well?

[ulan, 2015-07-24 14:32:48]

> One quick note -- I'll address the comments in a bit -- the method is named
> ParseES5DateTime, so should we update that as well?
Yes, let's update it to keep it consistent.

[hichris123, 2015-07-24 15:10:04]

Alright, I think I updated everything to reflect the new behavior and that it's
using ES6 behavior vs ES5 behavior.

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h
File src/dateparser-inl.h (right):

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or legacy
dates compatible
On 2015/07/24 13:56:25, ulan wrote:
> Please update this comment to ES6.

Done.

https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
src/dateparser-inl.h:43: //           (following the ES6 standard vs. ES5).
On 2015/07/24 13:56:25, ulan wrote:
> We can now drop the part in parenthesis. 

Done.

[ulan, 2015-07-24 15:20:42]

On 2015/07/24 15:10:04, hichris123 wrote:
> Alright, I think I updated everything to reflect the new behavior and that
it's
> using ES6 behavior vs ES5 behavior.
> 
> https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h
> File src/dateparser-inl.h (right):
> 
>
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
> src/dateparser-inl.h:25: // Accept ES5 ISO 8601 date-time-strings or legacy
> dates compatible
> On 2015/07/24 13:56:25, ulan wrote:
> > Please update this comment to ES6.
> 
> Done.
> 
>
https://codereview.chromium.org/1229903004/diff/60001/src/dateparser-inl.h#ne...
> src/dateparser-inl.h:43: //           (following the ES6 standard vs. ES5).
> On 2015/07/24 13:56:25, ulan wrote:
> > We can now drop the part in parenthesis. 
> 
> Done.

Looks good.

[hichris123, 2015-07-24 15:28:30]

On 2015/07/24 15:20:42, ulan wrote:
> Looks good.

Needed to fix one test (not sure why it didn't fail earlier, but...). I'm going
to send it to the CQ if a few trybot runs are fine. Sound good?

[hichris123, 2015-07-24 16:54:38]

The CQ bit was checked by hichris123@gmail.com

[hichris123, 2015-07-24 16:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1229903004/#ps120001
(title: "Actually fix test")

[commit-bot: I haz the power, 2015-07-24 16:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229903004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1229903004/120001

[commit-bot: I haz the power, 2015-07-24 17:19:39]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-24 17:19:59]

Patchset 7 (id:??) landed as
https://crrev.com/f06754a8e1d305a43560705f6c167d85d40e602d
Cr-Commit-Position: refs/heads/master@{#29854}