Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1403123002: Store texture target on GrGLTexture. This is in preparation for using texture targets other than 2D. (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Store texture target on GrGLTexture. This is in preparation for using texture targets other than 2D. Committed: https://skia.googlesource.com/skia/+/10528f1d5838ae1cac015024c4e8731484f888d1

Patch Set 1 #

Patch Set 2 : working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -86 lines) Patch
M src/gpu/gl/GrGLGpu.h View 1 2 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 28 chunks +78 lines, -83 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 2 months ago (2015-10-14 18:12:25 UTC) #2
bsalomon
PTAL
5 years, 2 months ago (2015-10-14 19:01:15 UTC) #3
joshualitt
On 2015/10/14 19:01:15, bsalomon wrote: > PTAL lgtm
5 years, 2 months ago (2015-10-14 19:46:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403123002/20001
5 years, 2 months ago (2015-10-14 19:47:06 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 19:54:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/10528f1d5838ae1cac015024c4e8731484f888d1

Powered by Google App Engine
This is Rietveld 408576698