Also print the exception when mksnapshot failed to compile extra code.

Also print the exception when mksnapshot failed to compile extra code.

Before, it would only print the exception when it failed to run the code

R=svenpanne@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14478

[jochen (gone - plz use gerrit), 2013-04-29 09:31:21]

plz review

[Sven Panne, 2013-04-29 11:23:36]

LGTM with the proposed simplification

https://codereview.chromium.org/14031036/diff/1/src/mksnapshot.cc
File src/mksnapshot.cc (right):

https://codereview.chromium.org/14031036/diff/1/src/mksnapshot.cc#newcode295
src/mksnapshot.cc:295: Local<String> message_string = message->Get();
Simpler:
-----------------------------------------
String::Utf8Value message_string(message->Get());
String::Utf8Value message_line (message->GetSourceLine());
fprintf(stderr, "%s at line %d\n", *message_string, message->GetLineNumber());
fprintf(stderr, "%s\n", *message_line);
for (int i = 0; i <= message->GetEndColumn(); i++) {
  fprintf(stderr, i < message->GetStartColumn() ? " " : "^");
}
fprintf(stderr, "\n");

[jochen (gone - plz use gerrit), 2013-04-29 11:38:28]

https://codereview.chromium.org/14031036/diff/1/src/mksnapshot.cc
File src/mksnapshot.cc (right):

https://codereview.chromium.org/14031036/diff/1/src/mksnapshot.cc#newcode295
src/mksnapshot.cc:295: Local<String> message_string = message->Get();
On 2013/04/29 11:23:36, Sven Panne wrote:
> Simpler:
> -----------------------------------------
> String::Utf8Value message_string(message->Get());
> String::Utf8Value message_line (message->GetSourceLine());
> fprintf(stderr, "%s at line %d\n", *message_string, message->GetLineNumber());
> fprintf(stderr, "%s\n", *message_line);
> for (int i = 0; i <= message->GetEndColumn(); i++) {
>   fprintf(stderr, i < message->GetStartColumn() ? " " : "^");
> }
> fprintf(stderr, "\n");

Done.

[Sven Panne, 2013-04-29 11:49:30]

Committed patchset #2 manually as r14478 (presubmit successful).