Also print the exception when mksnapshot failed to compile extra code.

src/mksnapshot.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 273 matching lines @@
                                    0, 1);
     if (result == BZ_OK) {
       *raw_data_size = decompressed_size;
     }
     return result;
   }
 };
 #endif
 
 
+void DumpException(Handle<Message> message) {
+  Local<String> message_string = message->Get();

[Sven Panne, 2013/04/29 11:23:36]

Simpler:
-----------------------------------------
String::Utf8Value message_string(message->Get());
String::Utf8Value message_line (message->GetSourceLine());
fprintf(stderr, "%s at line %d\n", *message_string, message->GetLineNumber());
fprintf(stderr, "%s\n", *message_line);
for (int i = 0; i <= message->GetEndColumn(); i++) {
  fprintf(stderr, i < message->GetStartColumn() ? " " : "^");
}
fprintf(stderr, "\n");

[jochen (gone - plz use gerrit), 2013/04/29 11:38:28]

Done.

+  Local<String> message_line = message->GetSourceLine();
+  int len = 2 + message_string->Utf8Length() + message_line->Utf8Length();
+  char* buf = new char(len);
+  message_string->WriteUtf8(buf);
+  fprintf(stderr, "%s at line %d\n", buf, message->GetLineNumber());
+  message_line->WriteUtf8(buf);
+  fprintf(stderr, "%s\n", buf);
+  int from = message->GetStartColumn();
+  int to = message->GetEndColumn();
+  int i;
+  for (i = 0; i < from; i++) fprintf(stderr, " ");
+  for ( ; i <= to; i++) fprintf(stderr, "^");
+  fprintf(stderr, "\n");
+}
+
+
 int main(int argc, char** argv) {
   // By default, log code create information in the snapshot.
   i::FLAG_log_code = true;
 
   // Print the usage if an error occurs when parsing the command line
   // flags or if the help flag is set.
   int result = i::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
   if (result > 0 || argc != 2 || i::FLAG_help) {
     ::printf("Usage: %s [flag] ... outfile\n", argv[0]);
     i::FlagList::PrintHelp();
@@ skipping 39 matching lines @@
         fprintf(stderr, "Failed to read '%s': errno %d\n", name, errno);
         exit(1);
       }
       i += read;
     }
     fclose(file);
     Local<String> source = String::New(chars);
     TryCatch try_catch;
     Local<Script> script = Script::Compile(source);
     if (try_catch.HasCaught()) {
-      fprintf(stderr, "Failure compiling '%s' (see above)\n", name);
+      fprintf(stderr, "Failure compiling '%s'\n", name);
+      DumpException(try_catch.Message());
       exit(1);
     }
     script->Run();
     if (try_catch.HasCaught()) {
       fprintf(stderr, "Failure running '%s'\n", name);
-      Local<Message> message = try_catch.Message();
-      Local<String> message_string = message->Get();
-      Local<String> message_line = message->GetSourceLine();
-      int len = 2 + message_string->Utf8Length() + message_line->Utf8Length();
-      char* buf = new char(len);
-      message_string->WriteUtf8(buf);
-      fprintf(stderr, "%s at line %d\n", buf, message->GetLineNumber());
-      message_line->WriteUtf8(buf);
-      fprintf(stderr, "%s\n", buf);
-      int from = message->GetStartColumn();
-      int to = message->GetEndColumn();
-      int i;
-      for (i = 0; i < from; i++) fprintf(stderr, " ");
-      for ( ; i <= to; i++) fprintf(stderr, "^");
-      fprintf(stderr, "\n");
+      DumpException(try_catch.Message());
       exit(1);
     }
     context->Exit();
   }
   // Make sure all builtin scripts are cached.
   { HandleScope scope(isolate);
     for (int i = 0; i < i::Natives::GetBuiltinsCount(); i++) {
       i::Isolate::Current()->bootstrapper()->NativesSourceLookup(i);
     }
   }
@@ skipping 34 matching lines @@
   sink.WriteSpaceUsed(
       "",
       ser.CurrentAllocationAddress(i::NEW_SPACE),
       ser.CurrentAllocationAddress(i::OLD_POINTER_SPACE),
       ser.CurrentAllocationAddress(i::OLD_DATA_SPACE),
       ser.CurrentAllocationAddress(i::CODE_SPACE),
       ser.CurrentAllocationAddress(i::MAP_SPACE),
       ser.CurrentAllocationAddress(i::CELL_SPACE));
   return 0;
 }