Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher.

chrome/installer/util/installer_state.h

Index: chrome/installer/util/installer_state.h
diff --git a/chrome/installer/util/installer_state.h b/chrome/installer/util/installer_state.h
index 46f5b5d84992f56d210a0fdbc2650c22dc6a3466..570f96eb75e45abbbba7f21c248d390111a2bd31 100644
--- a/chrome/installer/util/installer_state.h
+++ b/chrome/installer/util/installer_state.h
@@ -117,6 +117,18 @@ class InstallerState {
     return ensure_google_update_present_;
   }
 
+  // A convenient method returning the presence of legacy App Launcher (with

[grt (UTC plus 2), 2013/05/16 14:55:52]

I don't think this method is a convenience in the same was as the others above.
It insulates the caller from an implementation detail rather than just providing
the caller with a simpler way to get at a piece of data. As such, please change
the comment to something along the lines of "Returns true if the legacy App
Launcher is installed and must be migrated to the new one."

[huangs, 2013/05/17 20:59:24]

Done (minor rephrasing).

+  // its own Add/Remove entry, and app_host.exe), which requires migration.
+  bool need_to_migrate_legacy_app_launcher() const {
+    return need_to_migrate_legacy_app_launcher_;
+  }
+
+  // A convenient method returning the need to create shortcuts for the

[grt (UTC plus 2), 2013/05/16 14:55:52]

Similar comment as above. How about "Returns true if shortcuts for the App
Launcher must be created."

[huangs, 2013/05/17 20:59:24]

Done (minor rephrasing).

+  // App Launcher, as specified by the --app-launcher switch.
+  bool create_app_launcher_shortcuts() const {
+    return create_app_launcher_shortcuts_;
+  }
+
   // The full path to the place where the operand resides.
   const base::FilePath& target_path() const { return target_path_; }
 
@@ -253,6 +265,10 @@ class InstallerState {
   bool msi_;
   bool verbose_logging_;
   bool ensure_google_update_present_;
+  // TODO(huangs): Remove by M30.
+  bool need_to_migrate_legacy_app_launcher_;
+  // TODO(huangs): Remove by M30.
+  bool create_app_launcher_shortcuts_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(InstallerState);