Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher.

chrome/installer/util/installer_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_INSTALLER_STATE_H_
 #define CHROME_INSTALLER_UTIL_INSTALLER_STATE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 93 matching lines @@
   Operation operation() const { return operation_; }
 
   // A convenience method returning level() == SYSTEM_LEVEL.
   // TODO(grt): Eradicate the bool in favor of the enum.
   bool system_install() const;
 
   // A convenience method returning package_type() == MULTI_PACKAGE.
   // TODO(grt): Eradicate the bool in favor of the enum.
   bool is_multi_install() const;
 
   // A convenient method returning the presence of the

[grt (UTC plus 2), 2013/05/16 14:55:52]

convenient -> convenience (The former means the method is convenient to use,
whereas the latter means it is provided as a convenience (which is the intent
here).)

[huangs, 2013/05/17 20:59:24]

Done.

   // --ensure-google-update-present switch.
   bool ensure_google_update_present() const {
     return ensure_google_update_present_;
   }
 
+  // A convenient method returning the presence of legacy App Launcher (with

[grt (UTC plus 2), 2013/05/16 14:55:52]

I don't think this method is a convenience in the same was as the others above.
It insulates the caller from an implementation detail rather than just providing
the caller with a simpler way to get at a piece of data. As such, please change
the comment to something along the lines of "Returns true if the legacy App
Launcher is installed and must be migrated to the new one."

[huangs, 2013/05/17 20:59:24]

Done (minor rephrasing).

+  // its own Add/Remove entry, and app_host.exe), which requires migration.
+  bool need_to_migrate_legacy_app_launcher() const {
+    return need_to_migrate_legacy_app_launcher_;
+  }
+
+  // A convenient method returning the need to create shortcuts for the

[grt (UTC plus 2), 2013/05/16 14:55:52]

Similar comment as above. How about "Returns true if shortcuts for the App
Launcher must be created."

[huangs, 2013/05/17 20:59:24]

Done (minor rephrasing).

+  // App Launcher, as specified by the --app-launcher switch.
+  bool create_app_launcher_shortcuts() const {
+    return create_app_launcher_shortcuts_;
+  }
+
   // The full path to the place where the operand resides.
   const base::FilePath& target_path() const { return target_path_; }
 
   // True if the "msi" preference is set or if a product with the "msi" state
   // flag is set is to be operated on.
   bool is_msi() const { return msi_; }
 
   // True if the --verbose-logging command-line flag is set or if the
   // verbose_logging master preferences option is true.
   bool verbose_logging() const { return verbose_logging_; }
@@ skipping 116 matching lines @@
   BrowserDistribution* multi_package_distribution_;
   base::Version critical_update_version_;
   Level level_;
   PackageType package_type_;
 #if defined(OS_WIN)
   HKEY root_key_;
 #endif
   bool msi_;
   bool verbose_logging_;
   bool ensure_google_update_present_;
+  // TODO(huangs): Remove by M30.
+  bool need_to_migrate_legacy_app_launcher_;
+  // TODO(huangs): Remove by M30.
+  bool create_app_launcher_shortcuts_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(InstallerState);
 };  // class InstallerState
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_INSTALLER_STATE_H_