Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7902)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 14031025: Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 70832b641e8244870b3d7785a7b632ca9a23f607..bf3dedfc768e3bdbd92166e857383eade387460b 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -484,14 +484,13 @@ bool CheckMultiInstallConditions(const InstallationState& original_state,
}
// Checks app host pre-install conditions, specifically that this is a
-// user-level multi-install. When the pre-install conditions are not
-// satisfied, the result is written to the registry (via WriteInstallerResult),
-// |status| is set appropriately, and false is returned.
-bool CheckAppHostPreconditions(const InstallationState& original_state,
- InstallerState* installer_state,
- installer::InstallStatus* status) {
+// multi-install. When the pre-install conditions are not satisfied, the result
+// is written to the registry (via WriteInstallerResult), |status| is set
+// appropriately, and false is returned.
+bool CheckAppLauncherPreconditions(const InstallationState& original_state,
+ InstallerState* installer_state,
+ installer::InstallStatus* status) {
if (installer_state->FindProduct(BrowserDistribution::CHROME_APP_HOST)) {
-
if (!installer_state->is_multi_install()) {
LOG(DFATAL) << "App Launcher requires multi install";
*status = installer::APP_HOST_REQUIRES_MULTI_INSTALL;
@@ -499,15 +498,6 @@ bool CheckAppHostPreconditions(const InstallationState& original_state,
installer_state->WriteInstallerResult(*status, 0, NULL);
return false;
}
-
- if (installer_state->system_install()) {
- LOG(DFATAL) << "App Launcher may only be installed at user-level.";
- *status = installer::APP_HOST_REQUIRES_USER_LEVEL;
- // No message string since there is nothing a user can do.
- installer_state->WriteInstallerResult(*status, 0, NULL);
- return false;
- }
-
}
return true;
@@ -525,7 +515,7 @@ bool CheckAppHostPreconditions(const InstallationState& original_state,
bool CheckPreInstallConditions(const InstallationState& original_state,
InstallerState* installer_state,
installer::InstallStatus* status) {
- if (!CheckAppHostPreconditions(original_state, installer_state, status)) {
+ if (!CheckAppLauncherPreconditions(original_state, installer_state, status)) {
DCHECK_NE(*status, installer::UNKNOWN_STATUS);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698