chrome/installer/util/chrome_app_host_distribution.cc - Issue 14031025: Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_app_host_distribution.cc

Issue 14031025: Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/chrome_app_host_operations.cc » ('j') | chrome/installer/util/installer_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/chrome_app_host_distribution.cc

diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc

index 3dfa5156d8d717ec26113b2440fb10446c1807c6..a1d06f6d4ee0246d8583abea3e859261f22313f9 100644

--- a/chrome/installer/util/chrome_app_host_distribution.cc

+++ b/chrome/installer/util/chrome_app_host_distribution.cc

@@ -10,6 +10,7 @@

#include "chrome/installer/util/chrome_app_host_distribution.h"

#include "base/string_util.h"

+#include "base/version.h"

#include "chrome/common/net/test_server_locations.h"

#include "chrome/installer/util/channel_info.h"

#include "chrome/installer/util/google_update_constants.h"

@@ -115,8 +116,8 @@ string16 ChromeAppHostDistribution::GetUninstallLinkName() {

}

string16 ChromeAppHostDistribution::GetUninstallRegPath() {

- return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\"

- L"Google Chrome App Launcher";

+ NOTREACHED();

+ return string16();

}

string16 ChromeAppHostDistribution::GetVersionKey() {