Save and restore State for ShellWindows, including panels

ui/base/ui_base_types.h

Index: ui/base/ui_base_types.h
diff --git a/ui/base/ui_base_types.h b/ui/base/ui_base_types.h
index 3eb46cab373cef5c7dde433d7d27a1bbab4374bc..2f1bcec9eaed0d4ad9d7cdc2ad187538483f6c11 100644
--- a/ui/base/ui_base_types.h
+++ b/ui/base/ui_base_types.h
@@ -17,7 +17,8 @@ enum WindowShowState {
   SHOW_STATE_MAXIMIZED  = 3,
   SHOW_STATE_INACTIVE   = 4,  // Views only, not persisted.
   SHOW_STATE_FULLSCREEN = 5,
-  SHOW_STATE_END        = 6   // The end of show state enum.
+  SHOW_STATE_DETACHED   = 6,  // Views only; detached panel.

[flackr, 2013/04/26 03:44:38]

I'm not sure about this. When panels are detached they behave like "normal"
windows so SHOW_STATE_NORMAL seems to make sense. How would this work with
panels attached to the side of a workspace later? I wonder if it wouldn't be
simpler to have SHOW_STATE_ATTACHED which seems less ambiguous.

[stevenjb, 2013/04/26 16:12:17]

I considered adding ATTACHED, but it actually makes the code more complex since
attached is the "normal" state for panels.

Also, I don't expect we will need to store "guttered" explicitly; if we restore
one ore more windows to an edge we should be able to automatically create a
gutter at that point.

All that said, if the consensus is that having an explicit ATTACHED state would
be more clear and worth the additional code, I can certainly make that change.

+  SHOW_STATE_END        = 7   // The end of show state enum.
 };
 
 // Dialog button identifiers used to specify which buttons to show the user.