Save and restore State for ShellWindows, including panels

ui/base/ui_base_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_UI_BASE_TYPES_H_
 #define UI_BASE_UI_BASE_TYPES_H_
 
 namespace ui {
 
 // Window "show" state.  These values are written to disk so should not be
 // changed.
 enum WindowShowState {
   // A default un-set state.
   SHOW_STATE_DEFAULT    = 0,
   SHOW_STATE_NORMAL     = 1,
   SHOW_STATE_MINIMIZED  = 2,
   SHOW_STATE_MAXIMIZED  = 3,
   SHOW_STATE_INACTIVE   = 4,  // Views only, not persisted.
   SHOW_STATE_FULLSCREEN = 5,
-  SHOW_STATE_END        = 6   // The end of show state enum.
+  SHOW_STATE_DETACHED   = 6,  // Views only; detached panel.

[flackr, 2013/04/26 03:44:38]

I'm not sure about this. When panels are detached they behave like "normal"
windows so SHOW_STATE_NORMAL seems to make sense. How would this work with
panels attached to the side of a workspace later? I wonder if it wouldn't be
simpler to have SHOW_STATE_ATTACHED which seems less ambiguous.

[stevenjb, 2013/04/26 16:12:17]

I considered adding ATTACHED, but it actually makes the code more complex since
attached is the "normal" state for panels.

Also, I don't expect we will need to store "guttered" explicitly; if we restore
one ore more windows to an edge we should be able to automatically create a
gutter at that point.

All that said, if the consensus is that having an explicit ATTACHED state would
be more clear and worth the additional code, I can certainly make that change.

+  SHOW_STATE_END        = 7   // The end of show state enum.
 };
 
 // Dialog button identifiers used to specify which buttons to show the user.
 enum DialogButton {
   DIALOG_BUTTON_NONE   = 0,
   DIALOG_BUTTON_OK     = 1,
   DIALOG_BUTTON_CANCEL = 2,
 };
 
 // Specifies the type of modality applied to a window. Different modal
 // treatments may be handled differently by the window manager.
 enum ModalType {
   MODAL_TYPE_NONE   = 0,  // Window is not modal.
   MODAL_TYPE_WINDOW = 1,  // Window is modal to its transient parent.
   MODAL_TYPE_CHILD  = 2,  // Window is modal to a child of its transient parent.
   MODAL_TYPE_SYSTEM = 3   // Window is modal to all other windows.
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_UI_BASE_TYPES_H_