** DO NO COMMIT ** for jake

** DO NO COMMIT ** for jake

This is a kind of a practice.
Will be removed soon.

BUG=none

[zino, 2015-10-14 07:51:37]

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
(left):

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp:479:
return m_imagePaint.getFilterQuality() == kLow_SkFilterQuality;
I think you will have to modify the imageSmoothingEnabled property as well.
If the imageSmoothingQuality property is added, this logic will be going wrong.

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
(right):

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp:497:
String
CanvasRenderingContext2DState::SkFilterQuality2imageSmoothingQuality(SkFilterQuality
quality) const
I think it is better to avoid unnecessary addition of methods.
You could move this logic to imageSmoothingQuality() method.
Also, you can use switch statement. (but anything is okay.)

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp:499:
if (quality == kLow_SkFilterQuality)
Please see: http://www.chromium.org/blink/coding-style#TOC-Line-breaking (3)

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp:511:
if (quality == "low")
ditto
('ditto' means that this is the same as above.)

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h
(right):

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h:147:
String SkFilterQuality2imageSmoothingQuality(SkFilterQuality) const;
We don't need these methods.

https://codereview.chromium.org/1402963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h:148:
SkFilterQuality imageSmoothingQuality2SkFilterQuality(String) const;
nit: There are unnecessary blanks at the end of this line.

[zino, 2016-12-13 17:51:24]

abcd