** DO NO COMMIT ** for jake

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "modules/canvas2d/CanvasRenderingContext2DState.h"
 
 #include "core/css/CSSFontSelector.h"
 #include "core/css/resolver/FilterOperationResolver.h"
 #include "core/css/resolver/StyleBuilder.h"
 #include "core/css/resolver/StyleResolverState.h"
 #include "core/paint/FilterEffectBuilder.h"
 #include "core/style/ComputedStyle.h"
 #include "modules/canvas2d/CanvasGradient.h"
 #include "modules/canvas2d/CanvasPattern.h"
 #include "modules/canvas2d/CanvasStyle.h"
 #include "platform/graphics/DrawLooperBuilder.h"
 #include "platform/graphics/filters/SkiaImageFilterBuilder.h"
 #include "platform/graphics/skia/SkiaUtils.h"
 #include "third_party/skia/include/effects/SkDashPathEffect.h"
 #include "third_party/skia/include/effects/SkDropShadowImageFilter.h"
 
 static const char defaultFont[] = "10px sans-serif";
 static const char defaultFilter[] = "none";
+static const char defaultImageSmoothingQuality[] = "low";
 
 namespace blink {
 
 CanvasRenderingContext2DState::CanvasRenderingContext2DState()
     : m_unrealizedSaveCount(0)
     , m_strokeStyle(CanvasStyle::createFromRGBA(SK_ColorBLACK))
     , m_fillStyle(CanvasStyle::createFromRGBA(SK_ColorBLACK))
     , m_shadowBlur(0)
     , m_shadowColor(Color::transparent)
     , m_globalAlpha(1)
@@ skipping 15 matching lines @@
     m_fillPaint.setAntiAlias(true);
     m_imagePaint.setStyle(SkPaint::kFill_Style);
     m_imagePaint.setAntiAlias(true);
     m_strokePaint.setStyle(SkPaint::kStroke_Style);
     m_strokePaint.setStrokeWidth(1);
     m_strokePaint.setStrokeCap(SkPaint::kButt_Cap);
     m_strokePaint.setStrokeMiter(10);
     m_strokePaint.setStrokeJoin(SkPaint::kMiter_Join);
     m_strokePaint.setAntiAlias(true);
     setImageSmoothingEnabled(true);
+    setImageSmoothingQuality(defaultImageSmoothingQuality);
 }
 
 CanvasRenderingContext2DState::CanvasRenderingContext2DState(const CanvasRenderingContext2DState& other, ClipListCopyMode mode)
     : CSSFontSelectorClient()
     , m_unrealizedSaveCount(other.m_unrealizedSaveCount)
     , m_unparsedStrokeColor(other.m_unparsedStrokeColor)
     , m_unparsedFillColor(other.m_unparsedFillColor)
     , m_strokeStyle(other.m_strokeStyle)
     , m_fillStyle(other.m_fillStyle)
     , m_strokePaint(other.m_strokePaint)
@@ skipping 398 matching lines @@
 void CanvasRenderingContext2DState::setImageSmoothingEnabled(bool enabled)
 {
     SkFilterQuality filterQuality = enabled ? kLow_SkFilterQuality : kNone_SkFilterQuality;
     m_strokePaint.setFilterQuality(filterQuality);
     m_fillPaint.setFilterQuality(filterQuality);
     m_imagePaint.setFilterQuality(filterQuality);
 }
 
 bool CanvasRenderingContext2DState::imageSmoothingEnabled() const
 {
     return m_imagePaint.getFilterQuality() == kLow_SkFilterQuality;

[zino, 2015/10/14 07:51:36]

I think you will have to modify the imageSmoothingEnabled property as well.
If the imageSmoothingQuality property is added, this logic will be going wrong.

 }
 
+void CanvasRenderingContext2DState::setImageSmoothingQuality(String quality)
+{
+    SkFilterQuality filterQuality = imageSmoothingQuality2SkFilterQuality(quality);
+    m_strokePaint.setFilterQuality(filterQuality);
+    m_fillPaint.setFilterQuality(filterQuality);
+    m_imagePaint.setFilterQuality(filterQuality);
+}
+
+String CanvasRenderingContext2DState::imageSmoothingQuality() const
+{
+    return SkFilterQuality2imageSmoothingQuality(m_imagePaint.getFilterQuality());
+}
+
+String CanvasRenderingContext2DState::SkFilterQuality2imageSmoothingQuality(SkFilterQuality quality) const

[zino, 2015/10/14 07:51:36]

I think it is better to avoid unnecessary addition of methods.
You could move this logic to imageSmoothingQuality() method.
Also, you can use switch statement. (but anything is okay.)

+{
+    if (quality == kLow_SkFilterQuality)

[zino, 2015/10/14 07:51:36]

Please see: http://www.chromium.org/blink/coding-style#TOC-Line-breaking (3)

+        return "low";
+    else if (quality == kMedium_SkFilterQuality)
+        return "medium";
+    else if (quality == kHigh_SkFilterQuality)
+        return "high";
+    else
+        return "none";
+}
+
+SkFilterQuality CanvasRenderingContext2DState::imageSmoothingQuality2SkFilterQuality(String quality) const
+{
+    if (quality == "low")

[zino, 2015/10/14 07:51:36]

ditto
('ditto' means that this is the same as above.)

+        return kLow_SkFilterQuality;
+    else if (quality == "medium")
+        return kMedium_SkFilterQuality;
+    else if (quality == "high")
+        return kHigh_SkFilterQuality;
+    else
+        return kNone_SkFilterQuality;
+}
+
 bool CanvasRenderingContext2DState::shouldDrawShadows() const
 {
     return alphaChannel(m_shadowColor) && (m_shadowBlur || !m_shadowOffset.isZero());
 }
 
 const SkPaint* CanvasRenderingContext2DState::getPaint(PaintType paintType, ShadowMode shadowMode, ImageType imageType) const
 {
     SkPaint* paint;
     switch (paintType) {
     case StrokePaintType:
@@ skipping 41 matching lines @@
         paint->setLooper(0);
         paint->setImageFilter(shadowAndForegroundImageFilter());
         return paint;
     }
     paint->setLooper(shadowAndForegroundDrawLooper());
     paint->setImageFilter(0);
     return paint;
 }
 
 } // blink