Issue 140293002: [telemetry] Remove archive check in PageSetArchiveInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140293002: [telemetry] Remove archive check in PageSetArchiveInfo. (Closed)

Created:
6 years, 11 months ago by dtu

Modified:
6 years, 11 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Remove archive check in PageSetArchiveInfo. There's already a robust check in page_runner. The extra check is messing up record_wpr. BUG=333609 TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/top_10_000.wpr; tools/perf/record_wpr page_sets/top_10.json; mv ~/.boto.bak ~/.boto Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245287

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -16 lines)			Patch
M	tools/telemetry/telemetry/page/page_runner.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_set.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_set_archive_info.py	View	2 chunks	+3 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/140293002/1

6 years, 11 months ago (2014-01-16 00:07:06 UTC) #3

Message was sent while issue was closed.

Change committed as 245287

Expand Messages | Collapse Messages