Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: tools/telemetry/telemetry/page/page_set_archive_info.py

Issue 140293002: [telemetry] Remove archive check in PageSetArchiveInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_set.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set_archive_info.py
diff --git a/tools/telemetry/telemetry/page/page_set_archive_info.py b/tools/telemetry/telemetry/page/page_set_archive_info.py
index 1a6aeafc467861ae477a063e1005944036c7ae1a..aada2a8c8c5942138bfe0cbd05fe6bb12e298695 100644
--- a/tools/telemetry/telemetry/page/page_set_archive_info.py
+++ b/tools/telemetry/telemetry/page/page_set_archive_info.py
@@ -7,7 +7,6 @@ import logging
import os
import re
import shutil
-import sys
from telemetry.page import cloud_storage
@@ -27,21 +26,12 @@ class PageSetArchiveInfo(object):
try:
cloud_storage.GetIfChanged(archive_path)
except (cloud_storage.CredentialsError,
- cloud_storage.PermissionError) as e:
+ cloud_storage.PermissionError):
if os.path.exists(archive_path):
# If the archive exists, assume the user recorded their own and
# simply warn.
- logging.warning('Could not download WPR archive: %s', archive_path)
- else:
- # If the archive doesn't exist, this is fatal.
- logging.error('Can not run without required WPR archive: %s. '
- 'If you believe you have credentials, follow the '
- 'instructions below. If you do not have credentials, '
- 'you may use record_wpr to make your own recording or '
- 'run against live sites with --allow-live-sites.',
- archive_path)
- logging.error(e)
- sys.exit(1)
+ logging.warning('Need credentials to update WPR archive: %s',
+ archive_path)
# Map from the relative path (as it appears in the metadata file) of the
# .wpr file to a list of urls it supports.
« no previous file with comments | « tools/telemetry/telemetry/page/page_set.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698