Issue 14028023: Ignore arch specific Makefiles when running "git status".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14028023: Ignore arch specific Makefiles when running "git status". (Closed)

Created:
7 years, 8 months ago by tfarina

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Ignore arch specific Makefiles when running "git status". This should make git ignore the following Makefiles: Makefile-armu Makefile-ia32 Makefile-mipsu Makefile-x64 R=svenpanne@chromium.org Patch from Thiago Farina <tfarina@chromium.org>;

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

When are these Makefile-* files generated? I've never seen them so far...

7 years, 8 months ago (2013-04-24 06:31:10 UTC) #2

tfarina

On 2013/04/24 06:31:10, Sven Panne wrote: > When are these Makefile-* files generated? I've never ...

7 years, 8 months ago (2013-04-24 09:58:47 UTC) #3

Jakob Kummerow

On 2013/04/24 09:58:47, tfarina wrote: > On 2013/04/24 06:31:10, Sven Panne wrote: > > When ...

7 years, 8 months ago (2013-04-24 11:26:57 UTC) #4

tfarina

7 years, 8 months ago (2013-04-24 12:03:27 UTC) #5

Message was sent while issue was closed.

On 2013/04/24 11:26:57, Jakob wrote:
> On 2013/04/24 09:58:47, tfarina wrote:
> > On 2013/04/24 06:31:10, Sven Panne wrote:
> > > When are these Makefile-* files generated? I've never seen them so far...
> > 
> > May be when running gyp? Otherwise I have no idea, sorry.
> 
> I agree with Sven -- AFAIK none of our build steps generate these files.
> Wherever you got them from, you can just delete them, and close this CL.

Yeah, it's weird. I didn't invent them. If I see them back I'll make sure to
know how I generated them. Thanks!

Closing this.

Expand Messages | Collapse Messages