Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 14028010: CrOS multi-profiles ProfileManager changes (Closed)

Created:
7 years, 8 months ago by Nikita (slow)
Modified:
7 years, 8 months ago
Reviewers:
sail
CC:
chromium-reviews, rginda+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -10 lines) Patch
M chrome/browser/chromeos/cros/network_library_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 10 chunks +69 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sail
LGTM I think this needs cleanup as soon as possible. https://codereview.chromium.org/14028010/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/14028010/diff/1/chrome/browser/profiles/profile_manager.cc#newcode664 ...
7 years, 8 months ago (2013-04-12 17:28:34 UTC) #1
Nikita (slow)
7 years, 8 months ago (2013-04-15 20:09:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r194217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698