Issue 14028010: CrOS multi-profiles ProfileManager changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14028010: CrOS multi-profiles ProfileManager changes (Closed)

Created:
7 years, 8 months ago by Nikita (slow)

Modified:
7 years, 8 months ago

Reviewers:
sail

CC:
chromium-reviews, rginda+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

CrOS multi-profiles ProfileManager changes Depends on https://codereview.chromium.org/14139003/ BUG=180903 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194217

Patch Set 2 : fix tests #

Created: 7 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -10 lines)
M	chrome/browser/chromeos/cros/network_library_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/chromeos/login/mock_user_manager.h	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/chromeos/login/mock_user_manager.cc	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/profiles/profile_manager.h	View	2 chunks	+10 lines, -3 lines	0 comments
M	chrome/browser/profiles/profile_manager.cc	View	10 chunks	+69 lines, -3 lines	0 comments
M	chrome/browser/profiles/profile_manager_unittest.cc	View	2 chunks	+6 lines, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sail

LGTM I think this needs cleanup as soon as possible. https://codereview.chromium.org/14028010/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/14028010/diff/1/chrome/browser/profiles/profile_manager.cc#newcode664 ...

7 years, 8 months ago (2013-04-12 17:28:34 UTC) #1

Nikita (slow)

7 years, 8 months ago (2013-04-15 20:09:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r194217 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14028010: CrOS multi-profiles ProfileManager changes (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Messages