Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1402783008: Supply separate flags for onBuildTileIndex (Closed)

Created:
5 years, 2 months ago by msarett
Modified:
5 years, 2 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Supply separate flags for onBuildTileIndex This is a follow up to: https://codereview.chromium.org/1401283003/ Supply separate flags for onBuildTileIndex Since png and jpeg's implementations of onBuildTileIndex rely on modifications to their underlying libraries, rather than whether we are running on Android, use separate flags that can be disabled independently. This will allow us to easily turn off the feature. It also is a step towards building and running on other platforms for testing (e.g. valgrind/ASAN to find memory leaks etc). BUG=skia: Committed: https://skia.googlesource.com/skia/+/fc06e9c0e621744654e231ae6fa4460d88c0e27e Committed: https://skia.googlesource.com/skia/+/c2d0bc5c20a2a87a49a18c657cd26fe1a23eb874

Patch Set 1 #

Patch Set 2 : We may need to define JPEG_INDEX_SUPPORTED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/images/SkJpegUtility.cpp View 1 5 chunks +9 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
msarett
5 years, 2 months ago (2015-10-14 21:26:04 UTC) #2
scroggo
LGTM Thanks!
5 years, 2 months ago (2015-10-14 21:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402783008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402783008/1
5 years, 2 months ago (2015-10-14 21:35:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fc06e9c0e621744654e231ae6fa4460d88c0e27e
5 years, 2 months ago (2015-10-14 21:42:49 UTC) #6
msarett
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1394433005/ by msarett@google.com. ...
5 years, 2 months ago (2015-10-14 22:20:59 UTC) #7
msarett
Leon, can you take another look at this?
5 years, 2 months ago (2015-10-15 12:58:03 UTC) #8
scroggo
On 2015/10/15 12:58:03, msarett wrote: > Leon, can you take another look at this? Sorry ...
5 years, 2 months ago (2015-10-15 20:08:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402783008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402783008/20001
5 years, 2 months ago (2015-10-15 20:09:00 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 20:18:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c2d0bc5c20a2a87a49a18c657cd26fe1a23eb874

Powered by Google App Engine
This is Rietveld 408576698