Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1402533003: Don't use base::MessageLoop::{Quit,QuitClosure} in mojo/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in mojo/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=sky@chromium.org Committed: https://crrev.com/f8812d5afcc531663f1ad4ddfcaefd49f54aeac0 Cr-Commit-Position: refs/heads/master@{#353587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M mojo/android/javatests/mojo_test_case.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/android/system/base_run_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/cpp/lib/application_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/background_application_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:10:48 UTC) #1
ki.stfu
ping
5 years, 2 months ago (2015-10-12 13:42:19 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-12 19:09:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402533003/1
5 years, 2 months ago (2015-10-12 19:20:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 20:29:27 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:30:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8812d5afcc531663f1ad4ddfcaefd49f54aeac0
Cr-Commit-Position: refs/heads/master@{#353587}

Powered by Google App Engine
This is Rietveld 408576698