Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: mojo/runner/android/background_application_loader_unittest.cc

Issue 1402533003: Don't use base::MessageLoop::{Quit,QuitClosure} in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/application/public/cpp/lib/application_impl.cc ('k') | mojo/runner/context.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/runner/android/background_application_loader.h" 5 #include "mojo/runner/android/background_application_loader.h"
6 6
7 #include "mojo/application/public/interfaces/application.mojom.h" 7 #include "mojo/application/public/interfaces/application.mojom.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace mojo { 10 namespace mojo {
11 namespace runner { 11 namespace runner {
12 namespace { 12 namespace {
13 13
14 class DummyLoader : public shell::ApplicationLoader { 14 class DummyLoader : public shell::ApplicationLoader {
15 public: 15 public:
16 DummyLoader() : simulate_app_quit_(true) {} 16 DummyLoader() : simulate_app_quit_(true) {}
17 ~DummyLoader() override {} 17 ~DummyLoader() override {}
18 18
19 // shell::ApplicationLoader overrides: 19 // shell::ApplicationLoader overrides:
20 void Load(const GURL& url, 20 void Load(const GURL& url,
21 InterfaceRequest<Application> application_request) override { 21 InterfaceRequest<Application> application_request) override {
22 if (simulate_app_quit_) 22 if (simulate_app_quit_)
23 base::MessageLoop::current()->Quit(); 23 base::MessageLoop::current()->QuitWhenIdle();
24 } 24 }
25 25
26 void DontSimulateAppQuit() { simulate_app_quit_ = false; } 26 void DontSimulateAppQuit() { simulate_app_quit_ = false; }
27 27
28 private: 28 private:
29 bool simulate_app_quit_; 29 bool simulate_app_quit_;
30 }; 30 };
31 31
32 // Tests that the loader can start and stop gracefully. 32 // Tests that the loader can start and stop gracefully.
33 TEST(BackgroundApplicationLoaderTest, StartStop) { 33 TEST(BackgroundApplicationLoaderTest, StartStop) {
34 scoped_ptr<shell::ApplicationLoader> real_loader(new DummyLoader()); 34 scoped_ptr<shell::ApplicationLoader> real_loader(new DummyLoader());
35 BackgroundApplicationLoader loader(real_loader.Pass(), "test", 35 BackgroundApplicationLoader loader(real_loader.Pass(), "test",
36 base::MessageLoop::TYPE_DEFAULT); 36 base::MessageLoop::TYPE_DEFAULT);
37 } 37 }
38 38
39 // Tests that the loader can load a service that is well behaved (quits 39 // Tests that the loader can load a service that is well behaved (quits
40 // itself). 40 // itself).
41 TEST(BackgroundApplicationLoaderTest, Load) { 41 TEST(BackgroundApplicationLoaderTest, Load) {
42 scoped_ptr<shell::ApplicationLoader> real_loader(new DummyLoader()); 42 scoped_ptr<shell::ApplicationLoader> real_loader(new DummyLoader());
43 BackgroundApplicationLoader loader(real_loader.Pass(), "test", 43 BackgroundApplicationLoader loader(real_loader.Pass(), "test",
44 base::MessageLoop::TYPE_DEFAULT); 44 base::MessageLoop::TYPE_DEFAULT);
45 ApplicationPtr application; 45 ApplicationPtr application;
46 loader.Load(GURL(), GetProxy(&application)); 46 loader.Load(GURL(), GetProxy(&application));
47 } 47 }
48 48
49 } // namespace 49 } // namespace
50 } // namespace runner 50 } // namespace runner
51 } // namespace mojo 51 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/application/public/cpp/lib/application_impl.cc ('k') | mojo/runner/context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698