Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1402493002: Add sync_interception.cc to the WinASan instrumentation blacklist (Closed)

Created:
5 years, 2 months ago by Reid Kleckner
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sync_interception.cc to the WinASan instrumentation blacklist Fixes test failures introduced in https://codereview.chromium.org/1294823003, due to sandbox interceptors running before ASan initialization. BUG=521298 TBR=thakis@chromium.org,jschuh@chromium.org,glider@chromium.org Committed: https://crrev.com/9b4299dbbdb54e69e03719a1e0e46b9d9aa50ffe Cr-Commit-Position: refs/heads/master@{#353325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/memory/asan/blacklist_win.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
Reid Kleckner
5 years, 2 months ago (2015-10-09 17:30:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402493002/1
5 years, 2 months ago (2015-10-09 17:33:12 UTC) #3
Nico
rs-lgtm
5 years, 2 months ago (2015-10-09 17:34:19 UTC) #4
Nico
rs-lgtm
5 years, 2 months ago (2015-10-09 17:34:22 UTC) #5
Alexander Potapenko
On 2015/10/09 17:33:12, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 2 months ago (2015-10-09 17:35:20 UTC) #6
Reid Kleckner
On 2015/10/09 17:35:20, Alexander Potapenko wrote: > Doesn't ASan understand __attribute__((no_sanitize("address"))) on Win? > I ...
5 years, 2 months ago (2015-10-09 17:44:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 17:46:39 UTC) #8
Reid Kleckner
I also noticed that changing the blacklist file forces a clean build, so the comments ...
5 years, 2 months ago (2015-10-09 17:47:13 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b4299dbbdb54e69e03719a1e0e46b9d9aa50ffe Cr-Commit-Position: refs/heads/master@{#353325}
5 years, 2 months ago (2015-10-09 17:47:35 UTC) #10
Nico
On 2015/10/09 17:47:13, Reid Kleckner wrote: > I also noticed that changing the blacklist file ...
5 years, 2 months ago (2015-10-09 18:00:51 UTC) #11
Alexander Potapenko
On 2015/10/09 17:47:13, Reid Kleckner wrote: > I also noticed that changing the blacklist file ...
5 years, 2 months ago (2015-10-09 18:05:03 UTC) #12
Alexander Potapenko
5 years, 2 months ago (2015-10-09 18:06:07 UTC) #13
Message was sent while issue was closed.
> That should work. What about disabling coverage instrumentation? I think we
also
> have to do that.

Does this blacklist file affect coverage instrumentation? I really hope it does
not.

Powered by Google App Engine
This is Rietveld 408576698