Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1294823003: Sandbox: Reenable tests that were flaking for being too slow. (Closed)

Created:
5 years, 4 months ago by rvargas (doing something else)
Modified:
5 years, 4 months ago
Reviewers:
jschuh
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Reenable tests that were flaking for being too slow. The timeouts were increased long time ago so presumably these tests should not fail anymore. BUG=137652 Committed: https://crrev.com/22ad4e30a3133145f9038a2441318f81b64432af Cr-Commit-Position: refs/heads/master@{#343497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M sandbox/win/src/unload_dll_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
PTAL
5 years, 4 months ago (2015-08-14 20:06:38 UTC) #2
jschuh
lgtm
5 years, 4 months ago (2015-08-14 21:14:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294823003/1
5 years, 4 months ago (2015-08-14 21:26:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 21:36:04 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 21:36:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22ad4e30a3133145f9038a2441318f81b64432af
Cr-Commit-Position: refs/heads/master@{#343497}

Powered by Google App Engine
This is Rietveld 408576698