Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1402453002: Parametrize some more constants that will be changing in MD. (Closed)

Created:
5 years, 2 months ago by Peter Kasting
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parametrize some more constants that will be changing in MD. BUG=519020 TEST=none R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/be358e5f7d4ff573ee5f951bc5640cfa316202e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 5 chunks +7 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
Peter Kasting
5 years, 2 months ago (2015-10-09 10:40:07 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-09 16:46:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be358e5f7d4ff573ee5f951bc5640cfa316202e9 Cr-Commit-Position: refs/heads/master@{#353423}
5 years, 2 months ago (2015-10-09 23:26:16 UTC) #4
Peter Kasting
5 years, 2 months ago (2015-10-09 23:26:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be358e5f7d4ff573ee5f951bc5640cfa316202e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698