Miscellaneous cleanup.

Miscellaneous cleanup.

* Rename a few things in the glass frame from "avatar" to "incognito", as the "avatar button" in that frame is only ever used for the incognito icon.
* Shorten and/or clarify variable names and comments.
* Condense code.
* Add some consts.
* A few changes to make diffs in upcoming patches smaller.
* Replace a few hardcoded constants with uses of existing layout constants.
* Remove unnecessary icon-painting functions in tab.cc; they were only used to draw the favicon, which doesn't need any of the special things they do.
* Move some class-scope constants to file/function-scope.
* Remove unnecessary "static"s on consts already in an anonymous namespace.

BUG=none
TEST=none
R=sky@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2a033fafae209cabc698a346fd589db337dc2868

[Peter Kasting, 2015-10-09 07:05:55]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-10-09 16:31:38]

LGTM - but consider the following.

https://codereview.chromium.org/1392193004/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/1392193004/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:1549: bounds.Inset(GetLayoutInsets(TAB));
Did you consider: SetBorder(Border::CreateEmptyBorer(GetLayoutInsets(TAB)), then
getting rid of GetInteriorBounds() and using GetContentsBounds()?

[commit-bot: I haz the power, 2015-10-09 23:00:27]

Patchset 3 (id:??) landed as
https://crrev.com/2a033fafae209cabc698a346fd589db337dc2868
Cr-Commit-Position: refs/heads/master@{#353410}

[Peter Kasting, 2015-10-09 23:00:50]

Committed patchset #3 (id:40001) manually as
2a033fafae209cabc698a346fd589db337dc2868 (presubmit successful).