Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 7239bc6afd28c93c593d4bb868cc037b77e0d9e7..eb2f4dc506daf423bf8641a64f9b8d491a26c9b0 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -940,10 +940,10 @@ void ManagePasswordsBubbleView::ShowBubble(
manage_passwords_bubble_->AdjustForFullscreen(
browser_view->GetBoundsInScreen());
}
- if (reason == ManagePasswordsBubbleModel::AUTOMATIC)
- manage_passwords_bubble_->GetWidget()->ShowInactive();
- else
- manage_passwords_bubble_->GetWidget()->Show();
+
+ manage_passwords_bubble_->ShowForReason(
+ reason == ManagePasswordsBubbleModel::AUTOMATIC ? AUTOMATIC
+ : USER_ACTION);
}
// static
@@ -978,8 +978,6 @@ ManagePasswordsBubbleView::ManagePasswordsBubbleView(
: views::kPanelVertMargin;
set_margins(gfx::Insets(top_margin, views::kPanelHorizMargin,
views::kPanelVertMargin, views::kPanelHorizMargin));
- if (anchor_view)
- anchor_view->SetActive(true);
mouse_handler_.reset(new WebContentMouseHandler(this));
}
@@ -1004,11 +1002,6 @@ void ManagePasswordsBubbleView::Close() {
LocationBarBubbleDelegateView::Close();
}
-void ManagePasswordsBubbleView::OnWidgetClosing(views::Widget* /*widget*/) {
- if (anchor_view_)
- anchor_view_->SetActive(false);
-}
-
bool ManagePasswordsBubbleView::ShouldShowCloseButton() const {
return model_.state() == password_manager::ui::PENDING_PASSWORD_STATE;
}

Powered by Google App Engine
This is Rietveld 408576698