Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 533fef3f80a0944ec94f9504e6c31b401b49a3d6..31e032d323796e6e4458adab5dea70e59a62e213 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -445,10 +445,6 @@ void LocationBarView::SetStarToggled(bool on) {
star_view_->SetToggled(on);
}
-void LocationBarView::SetTranslateIconToggled(bool on) {
- translate_icon_view_->SetToggled(on);
-}
-
gfx::Point LocationBarView::GetOmniboxViewOrigin() const {
gfx::Point origin(omnibox_view_->bounds().origin());
origin.set_x(GetMirroredXInView(origin.x()));
@@ -1013,8 +1009,6 @@ bool LocationBarView::RefreshSaveCreditCardIconView() {
command_updater()->UpdateCommandEnabled(IDC_SAVE_CREDIT_CARD_FOR_PAGE,
enabled);
save_credit_card_icon_view_->SetVisible(enabled);
- if (enabled)
- save_credit_card_icon_view_->SetToggled(controller->IsIconToggled());
return was_visible != save_credit_card_icon_view_->visible();
}
@@ -1028,7 +1022,6 @@ void LocationBarView::RefreshTranslateIcon() {
bool enabled = language_state.translate_enabled();
command_updater()->UpdateCommandEnabled(IDC_TRANSLATE_PAGE, enabled);
translate_icon_view_->SetVisible(enabled);
- translate_icon_view_->SetToggled(language_state.IsPageTranslated());
if (!enabled)
TranslateBubbleView::CloseBubble();
}

Powered by Google App Engine
This is Rietveld 408576698