Update location bar bubble/icon behavior.

chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_
 
 #include "base/macros.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/views/bubble/bubble_delegate.h"
 
 namespace content {
 class NotificationDetails;
 class NotificationSource;
 class WebContents;
 };
 
 // Base class for bubbles that are shown from location bar icons. The bubble
 // will automatically close when the browser transitions in or out of fullscreen
 // mode.
 class LocationBarBubbleDelegateView : public views::BubbleDelegateView,
                                       public content::NotificationObserver {
  public:
+  enum DisplayReason { AUTOMATIC, USER_ACTION };

[Peter Kasting, 2015/11/10 00:24:18]

I'm not opposed to adding this, but it seems like if it's worth adding (versus
just using a bool), we should at least use it in every subclass of this (e.g.
SaveCardBubbleViews::Show()), if not everywhere in the CL.

This would also be useful in replacing some similar one-off ways we already
record this kind of thing, e.g. ManagePasswordsBubbleModel::AUTOMATIC, though I
haven't looked closely to ensure it's possible to refer to this everywhere
necessary.

Also, you might want to clarify here what these mean.  For example, if the
translate prompt is showing, and I click to "translate" the current page, and as
a result the "this page has been translated" bubble appears, is that a "user
action" or "automatic"?  "User action" could mean "icon clicked", or it could
mean "bubble shown during processing of some sort of user action somewhere in
the browser", or something in between.  (If it's the first, BTW, maybe
ICON_CLICKED would be a better enum value?)

[Evan Stade, 2015/11/10 19:18:26]

Done, but I left the enum value as USER_GESTURE to match all the various call
sites for bubbles.

+
   LocationBarBubbleDelegateView(views::View* anchor_view,
                                 content::WebContents* web_contents);
   ~LocationBarBubbleDelegateView() override;
 
+  // Displays the bubble as a result of |reason|.

[Peter Kasting, 2015/11/10 00:24:18]

You might want to note what we do differently in these cases.  For example, I
didn't realize that the bubble's active state (not just its appearance) differed
between the two.

[Evan Stade, 2015/11/10 19:18:26]

I don't like writing this type of comment because what's true today is not true
tomorrow, and there's no compiler for comments to make sure they stay correct.
The implementation is really short and easy to read, so that is the best
documentation. But I tried to improve this comment.

+  void ShowForReason(DisplayReason reason);
+
   // content::NotificationObserver:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override;
 
  protected:
   // Closes the bubble.
   virtual void Close();
 
   // If the bubble is not anchored to a view, places the bubble in the top right
   // (left in RTL) of the |screen_bounds| that contain web contents's browser
   // window. Because the positioning is based on the size of the bubble, this
   // must be called after the bubble is created.
   void AdjustForFullscreen(const gfx::Rect& screen_bounds);
 
  private:
   // Used to register for fullscreen change notifications.
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarBubbleDelegateView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_