Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index b9183f5e709b5551c57cd4d2df095c318fbf0d98..4015efa9025f4a0e12ca7a22e4b3dd2f6b3e0b04 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -855,7 +855,7 @@ void BrowserView::SetStarredState(bool is_starred) {
}
void BrowserView::SetTranslateIconToggled(bool is_lit) {
- GetLocationBarView()->SetTranslateIconToggled(is_lit);
+ // Translate icon is never active on Views.
}
void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,
@@ -1280,11 +1280,12 @@ void BrowserView::ShowBookmarkAppBubble(
autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
content::WebContents* web_contents,
- autofill::SaveCardBubbleController* controller) {
- autofill::SaveCardBubbleView* view = new autofill::SaveCardBubbleViews(
+ autofill::SaveCardBubbleController* controller,
+ bool is_user_gesture) {
+ autofill::SaveCardBubbleViews* view = new autofill::SaveCardBubbleViews(
GetToolbarView()->GetSaveCreditCardBubbleAnchor(), web_contents,
controller);
- view->Show();
+ view->Show(is_user_gesture);
return view;
}

Powered by Google App Engine
This is Rietveld 408576698