Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1402253002: CrOS: Load Chromite pins from JSON. (Closed)

Created:
5 years, 2 months ago by dnj
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

CrOS: Load Chromite pins from JSON. Rework `cros_chromite` script to load its Chromite pins from a JSON file instead of having be embedded in the script itself. This will allow external tools to easily update Chromite pins. BUG=chromium:543290 TEST=local Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297261

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase (without pin JSON). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -325 lines) Patch
M .DEPS.git View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M masters/master.chromiumos/chromiumos_board_config.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/common/cros_chromite.py View 11 chunks +75 lines, -36 lines 0 comments Download
M scripts/common/env.py View 2 chunks +8 lines, -1 line 0 comments Download
M scripts/common/unittests/cros_chromite_test.py View 4 chunks +22 lines, -7 lines 0 comments Download
M scripts/slave/unittests/recipe_lint_test.py View 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/tools/cros/cros_builder_convert.py View 1 chunk +0 lines, -273 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
dnj
PTAL This has an internal component patch: https://chromereviews.googleplex.com/272847013 This is the first step in the ...
5 years, 2 months ago (2015-10-15 18:46:47 UTC) #2
dnj (Google)
(ping!)
5 years, 2 months ago (2015-10-16 21:06:53 UTC) #4
ghost stip (do not use)
lgtm https://chromiumcodereview.appspot.com/1402253002/diff/1/scripts/common/env.py File scripts/common/env.py (right): https://chromiumcodereview.appspot.com/1402253002/diff/1/scripts/common/env.py#newcode318 scripts/common/env.py:318: sys_paths = [p for p in sys.path I ...
5 years, 2 months ago (2015-10-21 16:17:23 UTC) #5
luqui1
lgtm
5 years, 2 months ago (2015-10-22 22:19:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402253002/1
5 years, 2 months ago (2015-10-22 23:11:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/2528)
5 years, 2 months ago (2015-10-22 23:13:39 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402253002/20001
5 years, 2 months ago (2015-10-22 23:18:20 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/2531)
5 years, 2 months ago (2015-10-22 23:22:19 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402253002/40001
5 years, 2 months ago (2015-10-22 23:30:00 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 23:33:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402253002/40001
5 years, 2 months ago (2015-10-22 23:40:55 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 23:44:17 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297261

Powered by Google App Engine
This is Rietveld 408576698