Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1393893004: Add `slave_alloc_update` tool. (Closed)

Created:
5 years, 2 months ago by dnj
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add `slave_alloc_update` tool. Add the `slave_alloc_update` tool, which regenerates slave allocations for waterfalls that are managed by the `common.slave_alloc` SlaveAllocator. In addition to the tool, this makes some supportive tweaks: - Update master directory identification logic in `chromium_utils` to use global environment `build`/`build_internal` directories instead of generating them itself. - Update master directory identification to handle master names that don't begin with `master.`. - Update `slave_alloc` to store state options in the allocator, rather than have them be passed in when the state is saved. This enables consistent state saving regardless of whether the waterfall or `slave_alloc_update` is operating. BUG=chromium:543290 TEST=local - Ran script myself, seems to work! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297262

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -31 lines) Patch
M masters/master.chromiumos/chromiumos_board_config.py View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromiumos/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/common/chromium_utils.py View 2 chunks +11 lines, -9 lines 1 comment Download
M scripts/common/slave_alloc.py View 3 chunks +25 lines, -20 lines 0 comments Download
A scripts/tools/slave_alloc_update.py View 1 chunk +81 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
dnj
PTAL This depends on: https://codereview.chromium.org/1402253002 This has an internal component patch: https://chromereviews.googleplex.com/270347013/ This is the ...
5 years, 2 months ago (2015-10-15 18:46:54 UTC) #3
ghost stip (do not use)
lgtm https://chromiumcodereview.appspot.com/1393893004/diff/1/scripts/common/chromium_utils.py File scripts/common/chromium_utils.py (right): https://chromiumcodereview.appspot.com/1393893004/diff/1/scripts/common/chromium_utils.py#newcode1263 scripts/common/chromium_utils.py:1263: if not mastername.startswith('master.'): weird. that should be for ...
5 years, 2 months ago (2015-10-21 16:26:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393893004/1
5 years, 2 months ago (2015-10-22 23:48:08 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 23:51:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297262

Powered by Google App Engine
This is Rietveld 408576698